Page MenuHomePhorge
Differential D78

Fix many warnings: #warning "Inclusion of header files from include/Qt is deprecated."
AcceptedPublic
Actions

Authored by dfaure on Jan 12 2016, 11:44 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Apr 15, 11:58 AM
Unknown Object (File)
Mon, Apr 15, 7:04 AM
Unknown Object (File)
Sat, Apr 13, 5:14 AM
Unknown Object (File)
Wed, Apr 10, 5:21 PM
Unknown Object (File)
Sat, Apr 6, 4:53 AM
Unknown Object (File)
Thu, Apr 4, 9:41 AM
Unknown Object (File)
Wed, Mar 27, 1:42 PM
Unknown Object (File)
Feb 29 2024, 4:31 PM
View All Files
Subscribers
None

Details

Reviewers
mollekopf
Summary

When using find_package(Qt4), QT_INCLUDES has include/QtCore before include/Qt (as it should be) but somehow leads to -isystem for include/QtCore and -I for include/Qt, so qglobal.h and others are picked up from include/Qt.




But we never hit this in KDE because we don't use find_package(Qt4) directly, we let find_package(KDE4) take care of it, somehow it doesn't lead to -isystem.
Diff Detail
Repository 
rLK libkolab 
Lint 
Lint Skipped
 
Unit 
Tests Skipped
 
Event Timeline
dfaure updated this revision to Diff 144.Jan 12 2016, 11:44 PM
dfaure retitled this revision from  to Fix many warnings: #warning "Inclusion of header files from include/Qt is deprecated.".
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: mollekopf.
dfaure set the repository for this revision to rLK libkolab.
dfaure added a project: KDE PIM Developers.
mollekopf accepted this revision.Jan 20 2016, 12:19 PM
mollekopf edited edge metadata.
Thanks for the patch =)



Sorry this took so long, I missed that there were reviews pending
This revision is now accepted and ready to land.Jan 20 2016, 12:19 PM
Revision Contents
Changeset List
PathSize
4 lines
Diff 144
View Options
CMakeLists.txt
Loading...