Page MenuHomePhorge
Differential D73

Suppress the use of stderr and stdout in Utils::logMessage() when compiled with -DNDEBUG (Ref. T934)
AbandonedPublic
Actions

Authored by vanmeeuwen on Dec 30 2015, 10:44 AM.
Tags
None
Referenced Files
F12821466: D73.id139.diff
Thu, Jun 13, 11:41 AM
F12812304: D73.id.diff
Thu, Jun 13, 7:27 AM
Unknown Object (File)
Wed, Jun 12, 2:16 PM
Unknown Object (File)
Wed, Jun 12, 4:42 AM
Unknown Object (File)
Mon, Jun 10, 11:27 AM
Unknown Object (File)
Mon, Jun 10, 6:07 AM
Unknown Object (File)
Wed, Jun 5, 3:27 PM
Unknown Object (File)
Mon, May 27, 2:46 AM
View All Files
Subscribers
mollekopf

Details

Reviewers
mollekopf
Group Reviewers
Library Developers
Maniphest Tasks
T934: Suppress the use of stdout and stderr
Summary

Suppress the use of stderr and stdout in Utils::logMessage() when compiled with -DNDEBUG

Test Plan

None

Diff Detail

Repository
rLKX libkolabxml
Branch
dev/T934-1.1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2412
Build 2279: arc lint + arc unit

Event Timeline

vanmeeuwen updated this revision to Diff 135.Dec 30 2015, 10:44 AM
vanmeeuwen retitled this revision from to Suppress the use of stderr and stdout in Utils::logMessage() when compiled with -DNDEBUG (Ref. T934).
vanmeeuwen updated this object.
vanmeeuwen edited the test plan for this revision. (Show Details)
vanmeeuwen added a reviewer: Library Developers.
vanmeeuwen added a task: T934: Suppress the use of stdout and stderr.Dec 30 2015, 10:47 AM
vanmeeuwen added a parent revision: D72: Suppress the use of stderr and stdout in Utils::logMessage() when compiled with -DNDEBUG (Ref. T934).
vanmeeuwen added a child revision: D74: Suppress the use of stderr and stdout in Utils::logMessage() when compiled with -DNDEBUG (Ref. T934).
vanmeeuwen planned changes to this revision.Dec 30 2015, 10:51 AM
vanmeeuwen updated this revision to Diff 138.Dec 30 2015, 10:54 AM
  • -DNDEBUG doesn't make it at all :/
vanmeeuwen updated this revision to Diff 139.Dec 30 2015, 10:55 AM
  • -DNDEBUG doesn't make it at all :/
mollekopf subscribed.Jan 20 2016, 12:15 PM

This unconditionally removes the output, so rather wrap it into

#ifndef NDEBUG
#endif

?

mollekopf requested changes to this revision.Jan 20 2016, 12:16 PM
mollekopf added a reviewer: mollekopf.
This revision now requires changes to proceed.Jan 20 2016, 12:16 PM
vanmeeuwen requested a review of this revision.Feb 4 2016, 12:36 AM
vanmeeuwen edited edge metadata.
In D73#1255, @mollekopf wrote:

This unconditionally removes the output, so rather wrap it into

#ifndef NDEBUG
#endif

?

That's what I had at https://git.kolab.org/D73?vs=on&id=135&whitespace=ignore-most#toc but that did not seem to do the job.

vanmeeuwen abandoned this revision.Jul 1 2016, 1:06 PM

Revision Contents
Changeset List

PathSize
src/
8 lines

Diff 135

View Options

src/utils.cpp

Loading...