fix return value of init_ldap()
ClosedPublic
Actions

Authored by dhoffend on Apr 9 2019, 9:51 PM.

Project Tags

None

Referenced Files

	F118325739: D737.1775758574.diff
	Wed, Apr 8, 6:16 PM

	F117923508: D737.1775439656.diff
	Sun, Apr 5, 1:40 AM

	F117406797: D737.1774828461.diff
	Sat, Mar 28, 11:54 PM

Subscribers

None

Details

Reviewers

machniak
vanmeeuwen

Commits

rACbbd4949ef530: fix return value of init_ldap()

Summary

init_ldap doesn't return true on success

autoconf doesn't lookup the username in ldap because init_ldap() always returns
null, but get_user() expects a non-false response.

Diff Detail

Repository

rAC autoconf

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dhoffend requested review of this revision.Apr 9 2019, 9:51 PM

dhoffend created this revision.

Harbormaster completed remote builds in B23558: Diff 1679.Apr 9 2019, 9:51 PM

That's a bug introduced by e544905221b and the fix makes sense.

This revision is now accepted and ready to land.Apr 10 2019, 6:26 AM

Closed by commit rACbbd4949ef530: fix return value of init_ldap(). · Explain WhyApr 10 2019, 10:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

Autodiscover.php

lines

Diff 1685

View Options

fix return value of init_ldap()ClosedPublicActions