Page MenuHomePhorge

fix return value of init_ldap()
ClosedPublic

Authored by dhoffend on Apr 9 2019, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 7:23 PM
Unknown Object (File)
Fri, Jan 17, 7:14 PM
Unknown Object (File)
Sat, Jan 11, 7:13 PM
Unknown Object (File)
Wed, Jan 8, 11:58 PM
Unknown Object (File)
Wed, Jan 8, 9:28 PM
Unknown Object (File)
Wed, Jan 8, 9:28 PM
Unknown Object (File)
Fri, Dec 27, 6:59 PM
Unknown Object (File)
Dec 21 2024, 11:51 PM
Subscribers
None

Details

Summary

init_ldap doesn't return true on success

autoconf doesn't lookup the username in ldap because init_ldap() always returns
null, but get_user() expects a non-false response.

Diff Detail

Repository
rAC autoconf
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dhoffend created this revision.

That's a bug introduced by e544905221b and the fix makes sense.

This revision is now accepted and ready to land.Apr 10 2019, 8:26 AM
This revision was automatically updated to reflect the committed changes.