fix return value of init_ldap()
ClosedPublic
Actions

Authored by dhoffend on Apr 9 2019, 11:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 4:11 PM

	Unknown Object (File)
	Fri, Oct 18, 11:30 PM

	Unknown Object (File)
	Sep 16 2024, 10:41 AM

	Unknown Object (File)
	Sep 12 2024, 10:47 PM

	Unknown Object (File)
	Sep 7 2024, 4:13 AM

	Unknown Object (File)
	Sep 7 2024, 3:33 AM

	Unknown Object (File)
	Sep 4 2024, 7:31 AM

	Unknown Object (File)
	Aug 25 2024, 9:32 AM

View All 78 Files

Subscribers

None

Details

Reviewers

machniak
vanmeeuwen

Commits

rACbbd4949ef530: fix return value of init_ldap()

Summary

init_ldap doesn't return true on success

autoconf doesn't lookup the username in ldap because init_ldap() always returns
null, but get_user() expects a non-false response.

Diff Detail

Repository

rAC autoconf

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dhoffend requested review of this revision.Apr 9 2019, 11:51 PM

dhoffend created this revision.

Harbormaster completed remote builds in B23558: Diff 1679.Apr 9 2019, 11:51 PM

That's a bug introduced by e544905221b and the fix makes sense.

This revision is now accepted and ready to land.Apr 10 2019, 8:26 AM

Closed by commit rACbbd4949ef530: fix return value of init_ldap() (authored by dhoffend, committed by machniak). · Explain WhyApr 10 2019, 12:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

Autodiscover.php

4 lines

Diff 1685

View Options

fix return value of init_ldap()ClosedPublicActions