Page MenuHomekolab.org

fix return value of init_ldap()
ClosedPublic

Authored by dhoffend on Apr 9 2019, 11:51 PM.

Details

Summary

init_ldap doesn't return true on success

autoconf doesn't lookup the username in ldap because init_ldap() always returns
null, but get_user() expects a non-false response.

Diff Detail

Repository
rAC autoconf
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dhoffend requested review of this revision.Apr 9 2019, 11:51 PM
dhoffend created this revision.
machniak accepted this revision.Apr 10 2019, 8:26 AM

That's a bug introduced by e544905221b and the fix makes sense.

This revision is now accepted and ready to land.Apr 10 2019, 8:26 AM
This revision was automatically updated to reflect the committed changes.