Page MenuHomePhorge

sync collectioncolor with vendor/color annotation
ClosedPublic

Authored by knauss on Nov 4 2015, 2:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 14, 10:01 PM
Unknown Object (File)
Sun, Jul 14, 10:01 PM
Unknown Object (File)
Sun, Jul 14, 9:59 PM
Unknown Object (File)
Wed, Jul 10, 8:07 PM
Unknown Object (File)
Mon, Jul 8, 8:47 AM
Unknown Object (File)
Thu, Jul 4, 6:40 AM
Unknown Object (File)
Wed, Jul 3, 5:36 AM
Unknown Object (File)
Sun, Jun 30, 10:11 AM
Subscribers
None

Diff Detail

Repository
rKPR kdepim-runtime
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

knauss retitled this revision from to sync collectioncolor with vendor/color annotation.
knauss added reviewers: bohlender, mollekopf.
resources/kolab/kolabresource.cpp
171

Doesn't this mean we don't set the folder type annotation on new folders if they don't have a color?
So changed would also have to be true on !kolabType.isEmpty()

mollekopf edited edge metadata.
This revision now requires changes to proceed.Nov 9 2015, 6:29 PM
resources/kolab/kolabresource.cpp
171

Yes, but this was the behaviour before, too. The comple logic was in a "if (!kolabType.isEmpty()) { " (l151). Now the annotations are pushed, if either the kolabType is set or there is a foldercolor.

Or do you mean we should not push the color to the server without kolabType set?

mollekopf edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 1:18 PM
This revision was automatically updated to reflect the committed changes.