Page MenuHomekolab.org

sync collectioncolor with vendor/color annotation
ClosedPublic

Authored by knauss on Nov 4 2015, 2:38 PM.

Diff Detail

Repository
rKPR kdepim-runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

knauss updated this revision to Diff 125.Nov 4 2015, 2:38 PM
knauss retitled this revision from to sync collectioncolor with vendor/color annotation.
knauss added reviewers: bohlender, mollekopf.
mollekopf added inline comments.Nov 9 2015, 6:29 PM
resources/kolab/kolabresource.cpp
171

Doesn't this mean we don't set the folder type annotation on new folders if they don't have a color?
So changed would also have to be true on !kolabType.isEmpty()

mollekopf requested changes to this revision.Nov 9 2015, 6:29 PM
mollekopf edited edge metadata.
This revision now requires changes to proceed.Nov 9 2015, 6:29 PM
knauss added inline comments.Nov 10 2015, 10:54 AM
resources/kolab/kolabresource.cpp
171

Yes, but this was the behaviour before, too. The comple logic was in a "if (!kolabType.isEmpty()) { " (l151). Now the annotations are pushed, if either the kolabType is set or there is a foldercolor.

Or do you mean we should not push the color to the server without kolabType set?

mollekopf accepted this revision.Nov 10 2015, 1:18 PM
mollekopf edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 1:18 PM
Closed by commit rKPRe907b9aef99f: sync collectioncolor with vendor/color annotation (authored by Sandro Knauß <mail@sandroknauss.de>). · Explain WhyNov 12 2015, 11:25 AM
This revision was automatically updated to reflect the committed changes.