Page MenuHomePhorge

sync collectioncolor with vendor/color annotation
ClosedPublic

Authored by knauss on Nov 4 2015, 2:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 10:35 AM
Unknown Object (File)
Feb 24 2024, 12:37 AM
Unknown Object (File)
Feb 15 2024, 8:40 AM
Unknown Object (File)
Feb 2 2024, 11:46 AM
Unknown Object (File)
Jan 19 2024, 8:50 AM
Unknown Object (File)
Jan 16 2024, 1:32 PM
Unknown Object (File)
Jan 15 2024, 9:00 PM
Unknown Object (File)
Dec 31 2023, 1:02 PM
Subscribers
None

Diff Detail

Repository
rKPR kdepim-runtime
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

knauss retitled this revision from to sync collectioncolor with vendor/color annotation.
knauss added reviewers: bohlender, mollekopf.
resources/kolab/kolabresource.cpp
171

Doesn't this mean we don't set the folder type annotation on new folders if they don't have a color?
So changed would also have to be true on !kolabType.isEmpty()

mollekopf edited edge metadata.
This revision now requires changes to proceed.Nov 9 2015, 6:29 PM
resources/kolab/kolabresource.cpp
171

Yes, but this was the behaviour before, too. The comple logic was in a "if (!kolabType.isEmpty()) { " (l151). Now the annotations are pushed, if either the kolabType is set or there is a foldercolor.

Or do you mean we should not push the color to the server without kolabType set?

mollekopf edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2015, 1:18 PM
This revision was automatically updated to reflect the committed changes.