Drop DTEND if DTSTART and DTEND are the same
ClosedPublic
Actions

Authored by mollekopf on Oct 28 2025, 3:32 PM.

Project Tags

None

Referenced Files

None

Subscribers

machniak

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rK151fbec838cd: Drop DTEND if DTSTART and DTEND are the same

Summary

Should be both correct and required (RFC5545 3.8.2.2) according to the RFC:

specifies a "DTSTART" property with a DATE value type but no
"DTEND" nor "DURATION" property, the event's duration is taken to
be one day. For cases where a "VEVENT" calendar component
specifies a "DTSTART" property with a DATE-TIME value type but no
"DTEND" property, the event ends on the same calendar date and
time of day specified by the "DTSTART" property.

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Oct 28 2025, 3:32 PM

mollekopf created this revision.

Harbormaster completed remote builds in B55779: Diff 16290.Oct 28 2025, 3:32 PM

mollekopf added a reviewer: Restricted Project.Oct 28 2025, 3:51 PM

machniak requested changes to this revision.Oct 29 2025, 7:20 AM

machniak subscribed.

machniak added inline comments.

src/app/Backends/DAV/Vevent.php
312	Shouldn't it be `>` instead of `==`? Thinking a bit more about this issue, maybe it would be better to set DTEND to DTSTART + 30 minutes. I'm curious what would Roundcube or Outlook do for an event with no DTEND. Also, it would be good to have a test in tests/Unit/Backends/DAV/VeventTest.php

This revision now requires changes to proceed.Oct 29 2025, 7:20 AM

mollekopf added inline comments.Oct 29 2025, 7:30 AM

src/app/Backends/DAV/Vevent.php
312	I guess it could be, at the moment it just fixes a narrow case that we know to exist. I would expect roundcube to be able to handle an event without dtend since it's a perfectly legal vevent, but who knows.

Added a test

I've opted to stick to the == comparison. We can reconsider if we actually see the other case in the wild,
but in general I think the intention is clear if dtstart==dtend, but when not it's just a broken event.
It's not unreasonable to just drop dtend in that case, but this seems like the most predictable approach.

Harbormaster completed remote builds in B55788: Diff 16299.Oct 29 2025, 8:01 AM

machniak accepted this revision.Oct 29 2025, 8:02 AM

This revision is now accepted and ready to land.Oct 29 2025, 8:02 AM

Closed by commit rK151fbec838cd: Drop DTEND if DTSTART and DTEND are the same. · Explain WhyOct 29 2025, 8:08 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rK151fbec838cd: Drop DTEND if DTSTART and DTEND are the same.