Paths

Table of Contentst

Differential D5352

Ignore the imap subscription state for activesync folders
ClosedPublic
Actions

Authored by mollekopf on Jun 12 2025, 10:06 AM.

Project Tags

None

Referenced Files

	F117778637: D5352.1775244922.diff
	Thu, Apr 2, 7:35 PM

	F117415548: D5352.1774829984.diff
	Sun, Mar 29, 12:19 AM

	F117366741: D5352.1774816800.diff
	Sat, Mar 28, 8:40 PM

Subscribers

Details

Reviewers

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPKcd1a9ed8c34d: Ignore the imap subscription state for activesync folders

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jun 12 2025, 10:06 AM

mollekopf created this revision.

Harbormaster completed remote builds in B54132: Diff 15405.Jun 12 2025, 10:06 AM

not tested yet

machniak requested changes to this revision.Jun 12 2025, 10:09 AM

machniak subscribed.

machniak added inline comments.

plugins/libkolab/lib/kolab_subscriptions.php
93	This code branch is for Kolab4 and for mail folders only. I would not change this here.
100	We need to replace `true` with `false` (or `null`) here.

This revision now requires changes to proceed.Jun 12 2025, 10:09 AM

mollekopf marked 2 inline comments as done.Jun 12 2025, 10:13 AM

mollekopf added inline comments.

plugins/libkolab/lib/kolab_subscriptions.php
93	I would change this anyways, so the behavior is consistent. I don't think having two layers of configuration really helps (first imap subscription, then activesync), so I'm for ignoring subscriptions here too. Do you have a reason not to?

Ignore subscriptions in the non-kolab4 branch too.

Harbormaster completed remote builds in B54144: Diff 15417.Jun 12 2025, 10:14 AM

Ok, maybe it's indeed less problematic this way.

This revision is now accepted and ready to land.Jun 12 2025, 10:15 AM

Closed by commit rRPKcd1a9ed8c34d: Ignore the imap subscription state for activesync folders. · Explain WhyJun 12 2025, 11:19 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rRPKcd1a9ed8c34d: Ignore the imap subscription state for activesync folders.

Revision Contents
Changeset List

Path

Size

plugins/

libkolab/

lib/

kolab_subscriptions.php

lines

Diff 15420

plugins/libkolab/lib/kolab_subscriptions.php

Loading...