Support backward timezones
AcceptedPublic
Actions

Authored by winterz on Aug 30 2015, 10:07 PM.

Details

Reviewers

mollekopf
• knauss

Summary

This patch modifies the zonetabconversion.py script to look also in the /usr/share/libtimezonemap/backward file for old timezones that have been renamed over the years. For example Asia/Calcutta is now known as Asia/Kolkata

this is useful because sometimes you encounter the older names in calendar incidence.

technically the patch is only the zonetabconversion.py script, but I included the new tztable.h it generates so you can see what the changes will be.

Diff Detail

Repository

rLKX libkolabxml

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

winterz updated this revision to Diff 102.Aug 30 2015, 10:07 PM

winterz retitled this revision from to Support backward timezones.

winterz updated this object.

winterz edited the test plan for this revision. (Show Details)

winterz set the repository for this revision to rLKX libkolabxml.

winterz added a project: KDE PIM.

winterz added reviewers: mollekopf, • knauss.

Looks fine.

This revision is now accepted and ready to land.Aug 31 2015, 11:12 AM

In D53#914, @knauss wrote:

Looks fine.

Although this patch is probably ok, it really doesn't address the issue I'm trying to fix... namely dealing nicely without outdated timezone names. the real fix seems to be needed in libkolab/conversion/timezoneconverter.cpp. in fact, that file has commented-out code that would fix the problem. the comment there is "slower but also finds outdated zones"

so I may look into that.

In D53#918, @winterz wrote:

In D53#914, @knauss wrote:

Looks fine.

Although this patch is probably ok, it really doesn't address the issue I'm trying to fix... namely dealing nicely without outdated timezone names. the real fix seems to be needed in libkolab/conversion/timezoneconverter.cpp. in fact, that file has commented-out code that would fix the problem. the comment there is "slower but also finds outdated zones"

so I may look into that.

AFAIR the problem was that this code didn't actually work and simply accepted whatever you gave it, so even invalid timezones ended up being accepted.