Paths

Table of Contentst

More strict external email validation
ClosedPublic
Actions

Authored by machniak on May 21 2025, 9:57 AM.

Project Tags

None

Referenced Files

	F117584196: D5259.1774862475.diff
	Sun, Mar 29, 9:21 AM

Subscribers

mollekopf

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rK9ab0008d2159: More strict external email validation

Summary

catch common mistakes like double dot
do not allow IP addresses in domain part

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.May 21 2025, 9:57 AM

machniak created this revision.

Harbormaster completed remote builds in B53598: Diff 15123.May 21 2025, 9:57 AM

mollekopf accepted this revision.May 28 2025, 9:40 AM

mollekopf subscribed.

mollekopf added inline comments.

src/tests/Unit/Rules/ExternalEmailTest.php
52	It would be nice to have some more valid examples including numbers such as @example123.com or even @123.com.

This revision is now accepted and ready to land.May 28 2025, 9:40 AM

Add test cases

Harbormaster completed remote builds in B53664: Diff 15156.May 28 2025, 10:09 AM

Closed by commit rK9ab0008d2159: More strict external email validation. · Explain WhyMay 28 2025, 10:09 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rK9ab0008d2159: More strict external email validation.

Revision Contents
Changeset List

Path

Size

src/

app/

Rules/

ExternalEmail.php

lines

tests/

Unit/

Rules/

ExternalEmailTest.php

lines

Diff 15159

View Options

src/app/Rules/ExternalEmail.php