- Skip plan selection if there is only one active plan
- Allow signup with a public domain to a group account plan
- Prefer 'group' over 'individual' plan when the plan is not defined on signup
- Improvements + tests
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rK43275900b87e: Signup: Hide plan selection step if there's only one plan
./phpunit
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/config/app.php | ||
---|---|---|
229 ↗ | (On Diff #14696) | Shouldn't the default be individual according to the code change? |
src/config/app.php | ||
---|---|---|
229 ↗ | (On Diff #14696) | Because we also change how signup works and that we allow group account signup with public domain now, I think that 'group' is a better default. Using plan titles anywhere is not a great solution anyway. Maybe using additional "is_default" flag in plans table would be a better solution. Or maybe we should just get any active plan, and not prefer any specific title. What do you think? As far as I see the default is used in two cases: 1) with signup invitations, 2) when user somehow provided invalid plan. |
src/config/app.php | ||
---|---|---|
229 ↗ | (On Diff #14696) | Having an is_default flag quickly becomes problematic because you can set multiple but you should only have one. Instead of going with a default perhaps the solution would be to skip the step if there is only one active plan, and otherwise don't skip? So there wouldn't really be a default, it's just you don't have to choose if there's only one option. In case of an invalid plan we should throw an error and not use a default I think. So I think the logic could just be:
|
- Dashboard elements visibility for a group account without a custom domain
- Get rid of default plan
- CS fix