Page MenuHomePhorge
Differential D5116

Move wallet processing to a background queue
ClosedPublic
Actions

Authored by mollekopf on Tue, Feb 25, 9:23 AM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKd2d744002396: Move wallet processing to a background queue

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Tue, Feb 25, 9:23 AM
mollekopf created this revision.
Harbormaster completed remote builds in B52758: Diff 14670.Tue, Feb 25, 9:23 AM
mollekopf added a reviewer: Restricted Project.Tue, Feb 25, 9:24 AM

Currently untested, do we need test adjustments?

machniak requested changes to this revision.Tue, Feb 25, 9:28 AM
machniak subscribed.

We can assert the queue in tests. Maybe add one assertion in tests/Feature/Jobs/WalletCheckTest.php

I think you need to add the queue to config/horizon.php.

This revision now requires changes to proceed.Tue, Feb 25, 9:28 AM
machniak added a comment.Tue, Feb 25, 9:46 AM

That assertion would be $this->assertSame(WalletCheck::QUEUE, $job->queue);.

mollekopf updated this revision to Diff 14678.Tue, Feb 25, 4:51 PM

Define queue in horizon.php, added test

Harbormaster completed remote builds in B52770: Diff 14678.Tue, Feb 25, 4:51 PM
machniak accepted this revision.Tue, Feb 25, 6:11 PM
This revision is now accepted and ready to land.Tue, Feb 25, 6:11 PM
Closed by commit rKd2d744002396: Move wallet processing to a background queue. · Explain WhyWed, Feb 26, 9:46 AM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rKd2d744002396: Move wallet processing to a background queue.

Revision Contents
Changeset List

PathSize
src/
app/
Jobs/
3 lines
3 lines
config/
4 lines
tests/
Feature/
Jobs/
3 lines

Diff 14680

View Options

src/app/Jobs/WalletCharge.php

Loading...
View Options

src/app/Jobs/WalletCheck.php

Loading...
View Options

src/config/horizon.php

Loading...
View Options

src/tests/Feature/Jobs/WalletCheckTest.php

Loading...