Paths

Table of Contentst

Differential D5106

Use a separate queue for mailing jobs, de-duplicate code
ClosedPublic
Actions

Authored by machniak on Tue, Feb 18, 2:44 PM.

Tags

None

Referenced Files

	F19032096: D5106.1742288774.diff
	Mon, Mar 17, 10:06 AM

	F19032048: D5106.1742287777.diff
	Mon, Mar 17, 9:49 AM

	F19026402: D5106.1742070387.diff
	Fri, Mar 14, 9:26 PM

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK734ef93c24f6: Use a separate queue for mailing jobs, de-duplicate code

Summary

Also keep all mail jobs together

Test Plan

./phpunit

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Tue, Feb 18, 2:44 PM

machniak created this revision.

Harbormaster completed remote builds in B52718: Diff 14638.Tue, Feb 18, 2:44 PM

Add mail queue to the Horizon config

Harbormaster completed remote builds in B52720: Diff 14640.Tue, Feb 18, 2:55 PM

Add missing MailJob.php file

Harbormaster completed remote builds in B52722: Diff 14642.Wed, Feb 19, 11:02 AM

mollekopf accepted this revision.Wed, Feb 19, 2:53 PM

mollekopf subscribed.

mollekopf added inline comments.

src/app/Jobs/Mail/PasswordRetentionJob.php
31	it seems to me doing this in either MailJob::__construct (and calling the parent constructor here), would be cleaner, but it doesn't really matter. Potentially we should even move this to CommonJob in light of https://phorge.apps.ocp04.ait-msp-infra.net/T439

This revision is now accepted and ready to land.Wed, Feb 19, 2:53 PM

Closed by commit rK734ef93c24f6: Use a separate queue for mailing jobs, de-duplicate code. · Explain WhyThu, Feb 20, 2:26 PM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rK734ef93c24f6: Use a separate queue for mailing jobs, de-duplicate code.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

PasswordRetentionCommand.php

2 lines

Wallet/

TrialEndCommand.php

2 lines

Http/

Controllers/

API/

PasswordResetController.php

4 lines

SignupController.php

4 lines

Jobs/

	Mail/

	PasswordResetJob.php
	PasswordResetEmail.php

25 lines

	PaymentJob.php
	PaymentEmail.php

21 lines

	PaymentMandateDisabledJob.php
	PaymentMandateDisabledEmail.php

21 lines

	SignupInvitationJob.php
	SignupInvitationEmail.php

26 lines

	TrialEndJob.php
	TrialEndEmail.php

22 lines

	Mail/
	Password/

	PasswordRetentionJob.php
	RetentionEmailJob.php

21 lines

Mail/

SignupVerificationJob.php

40 lines

24 lines

Password/

RetentionEmailJob.php

PasswordResetEmail.php

PaymentEmail.php

PaymentMandateDisabledEmail.php

SignupInvitationEmail.php

SignupVerificationEmail.php

SignupVerificationSMS.php

TrialEndEmail.php

Observers/

SignupInvitationObserver.php

4 lines

Providers/

Payment/

4 lines

2 lines

config/

4 lines

tests/

Feature/

Console/

PasswordRetentionTest.php

13 lines

Wallet/

TrialEndTest.php

4 lines

Controller/

PasswordResetTest.php

4 lines

PaymentsCoinbaseTest.php

4 lines

PaymentsMollieEuroTest.php

24 lines

PaymentsMollieTest.php

24 lines

PaymentsStripeTest.php

22 lines

10 lines

Jobs/

	Mail/

	PasswordResetJobTest.php
	PasswordResetEmailTest.php

18 lines

	PaymentJobTest.php
	PaymentEmailTest.php

24 lines

	PaymentMandateDisabledJobTest.php
	PaymentMandateDisabledEmailTest.php

18 lines

	SignupInvitationJobTest.php
	SignupInvitationEmailTest.php

14 lines

	SignupVerificationJobTest.php
	SignupVerificationEmailTest.php

18 lines

	TrialEndJobTest.php
	TrialEndEmailTest.php

18 lines

	Mail/
	Password/

	PasswordRetentionJobTest.php
	RetentionEmailJobTest.php

17 lines

Password/

RetentionEmailJobTest.php

PasswordResetEmailTest.php

PaymentEmailTest.php

PaymentMandateDisabledEmailTest.php

SignupInvitationEmailTest.php

SignupVerificationEmailTest.php

TrialEndEmailTest.php

SignupInvitationTest.php

12 lines

Diff 14652

src/app/Console/Commands/PasswordRetentionCommand.php

Loading...

src/app/Console/Commands/Wallet/TrialEndCommand.php

Loading...

src/app/Http/Controllers/API/PasswordResetController.php

Loading...

src/app/Http/Controllers/API/SignupController.php

Loading...

src/app/Jobs/Mail/PasswordResetJob.php

Loading...

src/app/Jobs/Mail/PasswordRetentionJob.php

Loading...

src/app/Jobs/Mail/PaymentJob.php

Loading...

src/app/Jobs/Mail/PaymentMandateDisabledJob.php

Loading...

src/app/Jobs/Mail/SignupInvitationJob.php

Loading...

src/app/Jobs/Mail/SignupVerificationJob.php

Loading...

src/app/Jobs/Mail/TrialEndJob.php

Loading...

src/app/Jobs/MailJob.php

Loading...

src/app/Jobs/Password/RetentionEmailJob.php

Loading...

src/app/Jobs/PasswordResetEmail.php

Loading...

src/app/Jobs/PaymentEmail.php

Loading...

src/app/Jobs/PaymentMandateDisabledEmail.php

Loading...

src/app/Jobs/SignupInvitationEmail.php

Loading...

src/app/Jobs/SignupVerificationEmail.php

Loading...

src/app/Jobs/SignupVerificationSMS.php

Loading...

src/app/Jobs/TrialEndEmail.php

Loading...

src/app/Observers/SignupInvitationObserver.php

Loading...

src/app/Providers/Payment/Mollie.php

Loading...

src/app/Providers/Payment/Stripe.php

Loading...

src/config/horizon.php

Loading...

src/tests/Feature/Console/PasswordRetentionTest.php

Loading...

src/tests/Feature/Console/Wallet/TrialEndTest.php

Loading...

src/tests/Feature/Controller/PasswordResetTest.php

Loading...

src/tests/Feature/Controller/PaymentsCoinbaseTest.php

Loading...

src/tests/Feature/Controller/PaymentsMollieEuroTest.php

Loading...

src/tests/Feature/Controller/PaymentsMollieTest.php

Loading...

src/tests/Feature/Controller/PaymentsStripeTest.php

Loading...

src/tests/Feature/Controller/SignupTest.php

Loading...

src/tests/Feature/Jobs/Mail/PasswordResetJobTest.php

Loading...

src/tests/Feature/Jobs/Mail/PasswordRetentionJobTest.php

Loading...

src/tests/Feature/Jobs/Mail/PaymentJobTest.php

Loading...

src/tests/Feature/Jobs/Mail/PaymentMandateDisabledJobTest.php

Loading...

src/tests/Feature/Jobs/Mail/SignupInvitationJobTest.php

Loading...

src/tests/Feature/Jobs/Mail/SignupVerificationJobTest.php

Loading...

src/tests/Feature/Jobs/Mail/TrialEndJobTest.php

Loading...

src/tests/Feature/Jobs/Password/RetentionEmailJobTest.php

Loading...

src/tests/Feature/Jobs/PasswordResetEmailTest.php

Loading...

src/tests/Feature/Jobs/PaymentEmailTest.php

Loading...

src/tests/Feature/Jobs/PaymentMandateDisabledEmailTest.php

Loading...

src/tests/Feature/Jobs/SignupInvitationEmailTest.php

Loading...

src/tests/Feature/Jobs/SignupVerificationEmailTest.php

Loading...

src/tests/Feature/Jobs/TrialEndEmailTest.php

Loading...

src/tests/Feature/SignupInvitationTest.php

Loading...