Page MenuHomePhorge
Differential D5040

user:resync: efficient resync for created/deleted users
ClosedPublic
Actions

Authored by mollekopf on Tue, Nov 26, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 9:42 AM
Unknown Object (File)
Sun, Dec 8, 1:11 AM
Unknown Object (File)
Sat, Dec 7, 8:35 AM
Unknown Object (File)
Sat, Dec 7, 3:09 AM
Unknown Object (File)
Fri, Dec 6, 11:15 PM
Unknown Object (File)
Fri, Dec 6, 8:50 PM
Unknown Object (File)
Fri, Dec 6, 5:41 PM
Unknown Object (File)
Fri, Dec 6, 1:39 PM
View All 26 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK845b6cd1fa0e: user:resync: efficient resync for created/deleted users
Summary

Instead of going over all users, we query for incomplete
creations/deletions separately to only retrieve users that actually
require a resync.

The resync job is only triggered when requesting an individual user,
and from the db status everything already seems in order.

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Tue, Nov 26, 2:05 PM
mollekopf created this revision.
Harbormaster completed remote builds in B52252: Diff 14420.Tue, Nov 26, 2:05 PM
mollekopf added a reviewer: Restricted Project.Tue, Nov 26, 2:06 PM
machniak requested changes to this revision.Tue, Nov 26, 2:10 PM
machniak subscribed.
machniak added inline comments.
src/app/Console/Commands/User/ResyncCommand.php
89

Here and above we should make use of $with_ldap variable, to make it working as expected on a normal Kolab4 installation not only at KolabNow.

This revision now requires changes to proceed.Tue, Nov 26, 2:10 PM
mollekopf updated this revision to Diff 14422.Tue, Nov 26, 3:49 PM
mollekopf retitled this revision from user:resync --created-only to user:resync: efficient resync for created/deleted users.
mollekopf edited the summary of this revision. (Show Details)

Rewrote resync to use separate queries for created/deleted

Passes all tests, the only functional difference is that if invoked with a single user account we always at least trigger the resyncjob (before the account could be detected as in sync).

Harbormaster completed remote builds in B52254: Diff 14422.Tue, Nov 26, 3:49 PM
mollekopf updated this revision to Diff 14424.Tue, Nov 26, 3:51 PM

Really only test the IMAP_READY status

Harbormaster completed remote builds in B52256: Diff 14424.Tue, Nov 26, 3:51 PM
mollekopf updated this revision to Diff 14428.Tue, Nov 26, 4:13 PM

Rely on onlyTrashed

Harbormaster completed remote builds in B52260: Diff 14428.Tue, Nov 26, 4:13 PM
machniak requested changes to this revision.Wed, Nov 27, 9:09 AM
machniak added inline comments.
src/app/Console/Commands/User/ResyncCommand.php
186

This job is not intended for deleted users. So, we need some sanity check here. And the test will need an adjustment.

This revision now requires changes to proceed.Wed, Nov 27, 9:09 AM
mollekopf updated this revision to Diff 14430.Wed, Nov 27, 9:50 AM
mollekopf marked an inline comment as done.

Avoid pushing resync jobs for deleted users

Harbormaster completed remote builds in B52262: Diff 14430.Wed, Nov 27, 9:51 AM
mollekopf marked an inline comment as done.Wed, Nov 27, 9:51 AM
mollekopf added inline comments.
src/app/Console/Commands/User/ResyncCommand.php
186

ok, that now also removes the functional change that we had in the test.

mollekopf marked an inline comment as done.Wed, Nov 27, 9:52 AM
machniak accepted this revision.Wed, Nov 27, 10:12 AM
This revision is now accepted and ready to land.Wed, Nov 27, 10:12 AM
Closed by commit rK845b6cd1fa0e: user:resync: efficient resync for created/deleted users (authored by mollekopf). · Explain WhyThu, Nov 28, 1:08 PM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rK845b6cd1fa0e: user:resync: efficient resync for created/deleted users.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
User/
183 lines
tests/
Feature/
Console/
User/
18 lines

Diff 14436

View Options

src/app/Console/Commands/User/ResyncCommand.php

Loading...
View Options

src/tests/Feature/Console/User/ResyncTest.php

Loading...