Page MenuHomePhorge
Differential D5034

Unrestrict users on signup with a 100% discount
ClosedPublic
Actions

Authored by machniak on Fri, Nov 22, 12:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 3:32 AM
Unknown Object (File)
Sat, Nov 30, 8:24 PM
Unknown Object (File)
Sat, Nov 30, 3:20 AM
Unknown Object (File)
Sat, Nov 30, 1:24 AM
Unknown Object (File)
Sat, Nov 30, 1:06 AM
Unknown Object (File)
Fri, Nov 29, 9:33 AM
Unknown Object (File)
Fri, Nov 29, 4:33 AM
Unknown Object (File)
Fri, Nov 29, 4:15 AM
View All 14 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK1115ebfb7470: Unrestrict users on signup with a 100% discount
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak requested review of this revision.Fri, Nov 22, 12:57 PM
machniak created this revision.
Harbormaster completed remote builds in B52218: Diff 14408.Fri, Nov 22, 12:57 PM
mollekopf accepted this revision.Fri, Nov 22, 1:02 PM
mollekopf subscribed.
mollekopf added inline comments.
src/tests/Feature/Controller/SignupTest.php
691–700

I suppose that's because the request comes from localhost when you execute tests in the pod, but I'm not sure why we don't run the request against the hostname (e.g. kolab.local), that then resolves to localhost.

This revision is now accepted and ready to land.Fri, Nov 22, 1:02 PM
Closed by commit rK1115ebfb7470: Unrestrict users on signup with a 100% discount (authored by machniak). · Explain WhyFri, Nov 22, 1:26 PM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK1115ebfb7470: Unrestrict users on signup with a 100% discount.

Revision Contents
Changeset List

PathSize
config.demo/
src/
database/
seeds/
1 line
src/
app/
Http/
Controllers/
API/
11 lines
tests/
Feature/
Controller/
26 lines

Diff 14410

View Options

config.demo/src/database/seeds/DiscountSeeder.php

Loading...
View Options

src/app/Http/Controllers/API/SignupController.php

Loading...
View Options

src/tests/Feature/Controller/SignupTest.php

Loading...