Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/mollekopf
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 52210 Build 18534: arc lint + arc unit
Event Timeline
Comment Actions
Questions:
- Is this good enough to detect inactivity?
- Is the degraded state good enough or do we need to check the wallet balance?
The query seems to currently be super slow, while the commented query executes reasonably fast in sql.
| src/app/Console/Commands/User/PurgeCommand.php | ||
|---|---|---|
| 39 | There's a potential for user error, if you write --min-age=2 but you intended 2y. I'd make 'd' obligatory for days or even remove that possibility. | |
| 58 | See App\Console\Command::handle() for how to ask a user for confirmation. I'd prefer that than just an option. | |
| 90 | I would probably use https://laravel.com/docs/10.x/queries#where-exists-clauses. | |
| 104 | I would add orderBy('created_at'). To start deleting from the oldest. | |
| 112 | This works only because of a bug in DeleteJob. It should not allow to be executed on a non-deleted user. We should do something different. | |
Comment Actions
just as an fyi, purging users became less of a priority, so I'm parking this diff for now.