Page MenuHomePhorge
Differential D5028

Disable the mandate if we retrieve a valid one
ClosedPublic
Actions

Authored by mollekopf on Thu, Nov 21, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 2:02 PM
Unknown Object (File)
Mon, Dec 9, 2:07 PM
Unknown Object (File)
Mon, Dec 9, 11:18 AM
Unknown Object (File)
Sun, Dec 8, 6:58 PM
Unknown Object (File)
Sat, Dec 7, 1:37 PM
Unknown Object (File)
Sat, Dec 7, 1:30 PM
Unknown Object (File)
Sat, Dec 7, 2:02 AM
Unknown Object (File)
Fri, Dec 6, 10:30 PM
View All 26 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK5d2734621d00: Disable the mandate if we retrieve an invalid one
Summary

Right now we just retry to retrieve the mandate, which will then fail
again. I'm not sure if there is a "self-healing" case where this
behaviour makes sense. Also, we may want to send an email to the user
when this happens (the paymentfailure one looks like it could match this
case).

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Thu, Nov 21, 9:59 PM
mollekopf created this revision.
Harbormaster completed remote builds in B52204: Diff 14396.Thu, Nov 21, 9:59 PM
mollekopf added a reviewer: Restricted Project.Thu, Nov 21, 10:00 PM
machniak requested changes to this revision.Fri, Nov 22, 8:42 AM
machniak subscribed.
machniak added inline comments.
src/app/Http/Controllers/API/V4/PaymentsController.php
396

We probably should not do this if $mandate['isPending'] === true or unset mandate_disabled when we activate the mandate (payment providers' webhook).

This revision now requires changes to proceed.Fri, Nov 22, 8:42 AM
mollekopf updated this revision to Diff 14426.Tue, Nov 26, 4:01 PM

Do not disable a pending mandate

Harbormaster completed remote builds in B52258: Diff 14426.Tue, Nov 26, 4:01 PM
machniak accepted this revision.Wed, Nov 27, 8:26 AM

This warning message is not that useful without a wallet ID, I suppose.

This revision is now accepted and ready to land.Wed, Nov 27, 8:26 AM
Closed by commit rK5d2734621d00: Disable the mandate if we retrieve an invalid one (authored by mollekopf). · Explain WhyThu, Nov 28, 1:08 PM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rK5d2734621d00: Disable the mandate if we retrieve an invalid one.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
4 lines

Diff 14438

View Options

src/app/Http/Controllers/API/V4/PaymentsController.php

Loading...