Page MenuHomePhorge
Differential D5022

Don't dispatch update jobs on deleted objects
ClosedPublic
Actions

Authored by machniak on Tue, Nov 19, 10:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 4:48 AM
Unknown Object (File)
Thu, Nov 28, 11:35 PM
Unknown Object (File)
Thu, Nov 28, 11:20 PM
Unknown Object (File)
Wed, Nov 27, 2:36 PM
Unknown Object (File)
Wed, Nov 27, 5:47 AM
Unknown Object (File)
Tue, Nov 26, 4:22 PM
Unknown Object (File)
Tue, Nov 26, 9:42 AM
Unknown Object (File)
Tue, Nov 26, 5:42 AM
View All 16 Files
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK65e919c6d350: Don't dispatch update jobs on deleted objects
Summary

we could use saveQueietly() in DeleteJobs, but this is a more generic approach.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak requested review of this revision.Tue, Nov 19, 10:28 AM
machniak created this revision.
Harbormaster completed remote builds in B52186: Diff 14384.Tue, Nov 19, 10:28 AM
mollekopf accepted this revision.Tue, Nov 19, 10:42 AM
This revision is now accepted and ready to land.Tue, Nov 19, 10:42 AM
Closed by commit rK65e919c6d350: Don't dispatch update jobs on deleted objects (authored by machniak). · Explain WhyTue, Nov 19, 11:41 AM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK65e919c6d350: Don't dispatch update jobs on deleted objects.

Revision Contents
Changeset List

PathSize
src/
app/
Observers/
4 lines
4 lines
4 lines
4 lines
4 lines
tests/
Feature/
8 lines
16 lines
Jobs/
Group/
5 lines
Resource/
6 lines
SharedFolder/
6 lines
User/
8 lines
16 lines
16 lines
10 lines

Diff 14386

View Options

src/app/Observers/DomainObserver.php

Loading...
View Options

src/app/Observers/GroupObserver.php

Loading...
View Options

src/app/Observers/ResourceObserver.php

Loading...
View Options

src/app/Observers/SharedFolderObserver.php

Loading...
View Options

src/app/Observers/UserObserver.php

Loading...
View Options

src/tests/Feature/DomainTest.php

Loading...
View Options

src/tests/Feature/GroupTest.php

Loading...
View Options

src/tests/Feature/Jobs/Group/DeleteTest.php

Loading...
View Options

src/tests/Feature/Jobs/Resource/DeleteTest.php

Loading...
View Options

src/tests/Feature/Jobs/SharedFolder/DeleteTest.php

Loading...
View Options

src/tests/Feature/Jobs/User/DeleteTest.php

Loading...
View Options

src/tests/Feature/ResourceTest.php

Loading...
View Options

src/tests/Feature/SharedFolderTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...