Previously if a client e.g. sent a modification resulting in syncKey=4,
but then sent another Sync with syncKey=3, the server would just respond
with syncKey=3 instead of 4, which in Outlooks case resulted in the
client resending the modification that lead to syncKey=4 over and over.
Details
Details
- Reviewers
machniak - Group Reviewers
Syncroton Developers - Commits
- rS5c49103e6ef0: Make sure we always respond with the latest sync key
Diff Detail
Diff Detail
- Repository
- rS syncroton
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/ext/Syncroton/Command/Sync.php | ||
|---|---|---|
| 971 | Let's rename _next to counterNext. I think resending data will be needed, especially if there are server modifications. We don't know why client sends the previous SyncKey, maybe it just lost the previous response. If we don't send what has been changed we're out of sync. | |
Comment Actions
We'll have to double check, but I think the only this we're not sending is the client modifications from the previous sync from the same client.
- Client send modification with synckey=3
- Server responds with synckey=4
- Client sends emtpy sync with synckey=3 (instead of 4)
- Server now responds with synckey=4, but doesn't report the modification again.