Differential D4628

IMAP_WITH_GROUPWARE_DEFAULT_FOLDERS
ClosedPublic
Actions

Authored by mollekopf on Jan 4 2024, 9:31 AM.

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rKd62a59539705: IMAP_WITH_GROUPWARE_DEFAULT_FOLDERS

Summary

So we don't have to override the imap config file in the deployment
config.

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jan 4 2024, 9:31 AM

mollekopf created this revision.

Harbormaster completed remote builds in B46289: Diff 13301.Jan 4 2024, 9:31 AM

This prevents that we have to replace the config/imap.php file, which works but is slightly annoying because we constantly have a modification in the git repo.

machniak subscribed.Jan 4 2024, 10:39 AM

machniak added inline comments.

src/config/imap.php
3	What is the reason for a function and this existence check?

mollekopf added inline comments.Jan 4 2024, 11:39 PM

src/config/imap.php
3	The reason for the function is because IMO this is a pretty clean way to include that if/else branch in the array. It could be done by assigning to a variable, do the modification, return the variable instead. The reason for the existence check is because I'm getting "function was declared before" errors otherwise at least during test execution. I did not investigate why exactly, but it wasn't immediately obvious from the backtrace to me (possible first it's included globally, and then loaded again during test execution or so).