Page MenuHomePhorge
Differential D4576

Better approach to log SQL queries
ClosedPublic
Actions

Authored by machniak on Nov 23 2023, 2:48 PM.
Tags
None
Referenced Files
F12010107: D4576.diff
Sat, May 4, 11:02 PM
Unknown Object (File)
Wed, Apr 17, 11:03 AM
Unknown Object (File)
Wed, Apr 17, 11:03 AM
Unknown Object (File)
Wed, Apr 17, 11:03 AM
Unknown Object (File)
Wed, Apr 17, 11:03 AM
Unknown Object (File)
Wed, Apr 17, 11:02 AM
Unknown Object (File)
Mon, Apr 15, 11:23 AM
Unknown Object (File)
Mon, Apr 15, 4:28 AM
View All 60 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK3bc86f99af50: Better approach to log SQL queries
Summary

It's a more clean solution, and allows to log transaction queries

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak requested review of this revision.Nov 23 2023, 2:48 PM
machniak created this revision.
Harbormaster completed remote builds in B45817: Diff 13141.Nov 23 2023, 2:48 PM
machniak updated this revision to Diff 13144.Nov 23 2023, 3:01 PM
  • Use event subscriber feature, cleanup
Harbormaster completed remote builds in B45820: Diff 13144.Nov 23 2023, 3:01 PM
machniak updated this revision to Diff 13147.Nov 23 2023, 3:04 PM
  • Add missing app.debug check
Harbormaster completed remote builds in B45823: Diff 13147.Nov 23 2023, 3:04 PM
mollekopf subscribed.Nov 24 2023, 1:19 PM
mollekopf added inline comments.
src/app/Providers/EventServiceProvider.php
19

This seems unrelated?

mollekopf accepted this revision.Nov 24 2023, 1:24 PM
This revision is now accepted and ready to land.Nov 24 2023, 1:24 PM
machniak added inline comments.Nov 25 2023, 4:37 PM
src/app/Providers/EventServiceProvider.php
19

This seems unrelated?

Right, This is unused code I cleaned up.

mollekopf added inline comments.Nov 28 2023, 11:57 AM
src/app/Providers/EventServiceProvider.php
19

Ok, I'd prefer unrelated things in a separate commit (doesn't require a separate review, or any review for cases like this). Doesn't really matter for this case.

Closed by commit rK3bc86f99af50: Better approach to log SQL queries (authored by machniak). · Explain WhyNov 29 2023, 11:35 AM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK3bc86f99af50: Better approach to log SQL queries.

Revision Contents
Changeset List

PathSize
src/
app/
Listeners/
81 lines
Providers/
36 lines
15 lines

Diff 13192

View Options

src/app/Listeners/SqlDebug.php

Loading...
View Options

src/app/Providers/AppServiceProvider.php

Loading...
View Options

src/app/Providers/EventServiceProvider.php

Loading...