Page MenuHomePhorge

Move user resync to a job
ClosedPublic

Authored by machniak on Oct 19 2023, 11:05 AM.
Tags
None
Referenced Files
F12313845: D4558.diff
Thu, May 23, 8:57 AM
Unknown Object (File)
Wed, May 22, 1:40 AM
Unknown Object (File)
Thu, May 16, 11:06 PM
Unknown Object (File)
Fri, May 10, 6:33 PM
Unknown Object (File)
Fri, May 10, 1:15 PM
Unknown Object (File)
Sat, May 4, 11:08 PM
Unknown Object (File)
Sat, May 4, 3:24 AM
Unknown Object (File)
Mon, Apr 29, 1:56 AM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKb83d74c2028c: Move user resync to a job
Summary

Normal CLI tools should not have access to LDAP/IMAP

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf subscribed.
mollekopf added inline comments.
src/tests/Feature/Jobs/User/CreateTest.php
44

This should be with_ldap once I think.

src/tests/Feature/Jobs/User/ResyncTest.php
56

This should be with_ldap once I think.

This revision is now accepted and ready to land.Oct 26 2023, 4:39 PM
This revision now requires changes to proceed.Oct 26 2023, 4:39 PM

Fix the test and then ship it.

In general I think for the with_imap/with_ldap/with_files options; The tests should respect the config and e.g. just not test the ldap side if with_ldap is false because that test will simply never succeed if ldap is not available.
Your choice to fix that in this commit or separately.

This revision is now accepted and ready to land.Oct 27 2023, 11:11 AM
This revision was automatically updated to reflect the committed changes.