Move user resync to a job
ClosedPublic
Actions

Authored by machniak on Oct 19 2023, 11:05 AM.

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rKb83d74c2028c: Move user resync to a job

Summary

Normal CLI tools should not have access to LDAP/IMAP

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Oct 19 2023, 11:05 AM

machniak created this revision.

Harbormaster completed remote builds in B44452: Diff 13075.Oct 19 2023, 11:05 AM

mollekopf accepted this revision.Oct 26 2023, 4:39 PM

mollekopf subscribed.

mollekopf added inline comments.

src/tests/Feature/Jobs/User/CreateTest.php
44	This should be with_ldap once I think.
src/tests/Feature/Jobs/User/ResyncTest.php
56	This should be with_ldap once I think.

This revision is now accepted and ready to land.Oct 26 2023, 4:39 PM

mollekopf requested changes to this revision.Oct 26 2023, 4:39 PM

This revision now requires changes to proceed.Oct 26 2023, 4:39 PM

Fix the test and then ship it.

In general I think for the with_imap/with_ldap/with_files options; The tests should respect the config and e.g. just not test the ldap side if with_ldap is false because that test will simply never succeed if ldap is not available.
Your choice to fix that in this commit or separately.