Page MenuHomePhorge
Differential D4388

Make Artisan to not require database connection when not needed, other improvements
ClosedPublic
Actions

Authored by machniak on Jun 19 2023, 2:21 PM.
Tags
None
Referenced Files
F12010707: D4388.diff
Sun, May 5, 12:19 AM
Unknown Object (File)
Fri, May 3, 11:17 PM
Unknown Object (File)
Tue, Apr 30, 7:34 PM
Unknown Object (File)
Mon, Apr 29, 2:11 AM
Unknown Object (File)
Wed, Apr 17, 10:42 AM
Unknown Object (File)
Wed, Apr 17, 10:42 AM
Unknown Object (File)
Wed, Apr 17, 10:42 AM
Unknown Object (File)
Wed, Apr 17, 10:42 AM
View All 87 Files
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK187586331670: Make Artisan to not require database connection when not needed, other…
Summary
  • remove requirement on DB connection to get object properties available for update
  • make all scalpel commands hidden (a few of them were not hidden)
  • removed some redundant code
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.Jun 19 2023, 2:21 PM
Harbormaster completed remote builds in B43418: Diff 12578.Jun 19 2023, 2:21 PM
machniak requested review of this revision.Jun 19 2023, 2:21 PM
machniak updated this revision to Diff 12584.Jun 19 2023, 3:13 PM
  • Cleanup
Harbormaster completed remote builds in B43424: Diff 12584.Jun 19 2023, 3:13 PM
machniak updated this revision to Diff 12590.Jun 21 2023, 10:53 AM
  • Use Reflection instead of DB schema
Harbormaster completed remote builds in B43439: Diff 12590.Jun 21 2023, 10:53 AM
machniak retitled this revision from Partial fix for Artisan performance issue, and other improvements to Make Artisan to not require database connection when not needed, other improvements.Jun 21 2023, 12:02 PM
machniak edited the summary of this revision. (Show Details)
machniak updated this revision to Diff 12596.Jun 21 2023, 12:05 PM
  • Add test
Harbormaster completed remote builds in B43442: Diff 12596.Jun 21 2023, 12:05 PM
mollekopf accepted this revision.Jul 17 2023, 10:03 AM
This revision is now accepted and ready to land.Jul 17 2023, 10:03 AM
Closed by commit rK187586331670: Make Artisan to not require database connection when not needed, other… (authored by machniak). · Explain WhyJul 17 2023, 3:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
5 lines
Commands/
Scalpel/
TenantSetting/
2 lines
2 lines
Wallet/
2 lines
WalletSetting/
2 lines
2 lines
2 lines
12 lines
38 lines
76 lines
tests/
Feature/
Console/
Scalpel/
Domain/
70 lines

Diff 12659

View Options

src/app/Console/Command.php

Loading...
View Options

src/app/Console/Commands/Scalpel/TenantSetting/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/Scalpel/TenantSetting/UpdateCommand.php

Loading...
View Options

src/app/Console/Commands/Scalpel/Wallet/SettingsCommand.php

Loading...
View Options

src/app/Console/Commands/Scalpel/WalletSetting/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/Scalpel/WalletSetting/UpdateCommand.php

Loading...
View Options

src/app/Console/ObjectCommand.php

Loading...
View Options

src/app/Console/ObjectCreateCommand.php

Loading...
View Options

src/app/Console/ObjectDeleteCommand.php

Loading...
View Options

src/app/Console/ObjectUpdateCommand.php

Loading...
View Options

src/tests/Feature/Console/Scalpel/Domain/UpdateCommandTest.php

Loading...