fixes error in Python3 running saslauthd.py in fork mode
Code harmonized with code in def run of kolabd/__init.py and wallace/init__.py
Details
Details
- Reviewers
sicherha - Group Reviewers
PyKolab Developers - Commits
- rP87463ed0703e: [Python 3] fork code harmonizing
Diff Detail
Diff Detail
- Repository
- rP pykolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Could you add to the summary of this differential a description of the concrete error that is being solved here? I presume that some part of Python (which one?) complained about one of the file descriptors for stdin/ stdout/ stderr being unavailable, but it would be great to make that explicit.
Comment Actions
with --fork
testsaslauthd -u user(@domain) -p password
0: NO "authentication failed"
- Logging error ---
Traceback (most recent call last):
File "/usr/lib/python3.x/logging/__init__.py", line 1037, in emit stream.write(msg + self.terminator)
BrokenPipeError: [Errno 32] Broken pipe
Call stack:
File "./saslauthd.py", line 43, in <module> saslauthd.run()
...
Message: "Authentication for 'user(@domain)' succeeded"
I tried to localize the error on other parts of the code, but I couldn't localize.
without --fork the code worked.
testsaslauthd -u user(@domain) -p password
0: OK "Success."
I just checked against the same fork code snippet on wallace and kolabd, C&P the missing code part and it worked.
So I just harmonized the fork code in def run on the daemon.