Page MenuHomePhorge
Differential D3403

[Python 3]basestring to six string_types
ClosedPublic
Actions

Authored by ghane on Feb 23 2022, 2:38 PM.

Details

Reviewers
sicherha
Group Reviewers
PyKolab
PyKolab Developers
Commits
rP1aeaee3ca41a: [Python 3]basestring to six string_types
Summary

Using for compatibility
from six import string_types
and
"string_types" for "basestring"
as it is still used in pykolab/utils.py

Diff Detail

Repository
rP pykolab
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ghane requested review of this revision.Feb 23 2022, 2:38 PM
ghane created this revision.
ghane mentioned this in T6805: Port pykolab to Python 3.Feb 23 2022, 2:45 PM
sicherha accepted this revision.Mar 12 2022, 11:11 AM
sicherha subscribed.

Looks good to me, thanks!

This revision is now accepted and ready to land.Mar 12 2022, 11:11 AM
Closed by commit rP1aeaee3ca41a: [Python 3]basestring to six string_types. · Explain WhyMar 13 2022, 8:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
13 lines
pykolab/
cli/
3 lines
3 lines
3 lines
sieve/
3 lines
imap/
4 lines
plugins/
sievemgmt/
3 lines
setup/
3 lines
xml/
6 lines
6 lines
wallace/
3 lines
3 lines

Diff 9706

View Options

bin/kolab_smtp_access_policy.py

Loading...
View Options

pykolab/cli/cmd_add_alias.py

Loading...
View Options

pykolab/cli/cmd_remove_mailaddress.py

Loading...
View Options

pykolab/cli/commands.py

Loading...
View Options

pykolab/cli/sieve/cmd_refresh.py

Loading...
View Options

pykolab/imap/__init__.py

Loading...
View Options

pykolab/plugins/sievemgmt/__init__.py

Loading...
View Options

pykolab/setup/components.py

Loading...
View Options

pykolab/xml/contact.py

Loading...
View Options

pykolab/xml/event.py

Loading...
View Options

wallace/module_invitationpolicy.py

Loading...
View Options

wallace/modules.py

Loading...