[Python 3]basestring to six string_types
ClosedPublic
Actions

Authored by ghane on Feb 23 2022, 2:38 PM.

Details

Reviewers

Group Reviewers

PyKolab
PyKolab Developers

Commits

rP1aeaee3ca41a: [Python 3]basestring to six string_types

Summary

Using for compatibility
from six import string_types
and
"string_types" for "basestring"
as it is still used in pykolab/utils.py

Diff Detail

Repository

rP pykolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ghane requested review of this revision.Feb 23 2022, 2:38 PM

ghane created this revision.

ghane mentioned this in T6805: Port pykolab to Python 3.Feb 23 2022, 2:45 PM

Looks good to me, thanks!

This revision is now accepted and ready to land.Mar 12 2022, 11:11 AM

Closed by commit rP1aeaee3ca41a: [Python 3]basestring to six string_types (authored by sicherha). · Explain WhyMar 13 2022, 8:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

bin/

kolab_smtp_access_policy.py

13 lines

pykolab/

cli/

cmd_add_alias.py

3 lines

cmd_remove_mailaddress.py

3 lines

commands.py

3 lines

sieve/

cmd_refresh.py

3 lines

imap/

__init__.py

4 lines

plugins/

sievemgmt/

__init__.py

3 lines

setup/

components.py

3 lines

xml/

contact.py

6 lines

event.py

6 lines

wallace/

module_invitationpolicy.py

3 lines

modules.py

3 lines

Diff 9829

View Options

bin/kolab_smtp_access_policy.py

View Options

pykolab/cli/cmd_add_alias.py

View Options

pykolab/cli/cmd_remove_mailaddress.py

View Options

pykolab/cli/commands.py

View Options

pykolab/cli/sieve/cmd_refresh.py

View Options

pykolab/imap/init.py

View Options

pykolab/plugins/sievemgmt/init.py

View Options

pykolab/setup/components.py

View Options

pykolab/xml/contact.py

View Options

pykolab/xml/event.py

View Options

wallace/module_invitationpolicy.py

View Options

[Python 3]basestring to six string_typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9829

bin/kolab_smtp_access_policy.py

pykolab/cli/cmd_add_alias.py

pykolab/cli/cmd_remove_mailaddress.py

pykolab/cli/commands.py

pykolab/cli/sieve/cmd_refresh.py

pykolab/imap/__init__.py

pykolab/plugins/sievemgmt/__init__.py

pykolab/setup/components.py

pykolab/xml/contact.py

pykolab/xml/event.py

wallace/module_invitationpolicy.py

wallace/modules.py

[Python 3]basestring to six string_types
ClosedPublic
Actions

Revision Contents
Changeset List

pykolab/imap/init.py

pykolab/plugins/sievemgmt/init.py