Page MenuHomePhorge
Differential D3391

[Python 3] Implicit relative imports fixes
ClosedPublic
Actions

Authored by ghane on Feb 21 2022, 11:45 PM.
Tags
None
Referenced Files
F11804382: D3391.id.diff
Fri, Apr 19, 7:20 AM
Unknown Object (File)
Wed, Apr 17, 9:11 AM
Unknown Object (File)
Sat, Apr 13, 12:08 PM
Unknown Object (File)
Fri, Apr 12, 7:26 AM
Unknown Object (File)
Fri, Apr 5, 9:01 PM
Unknown Object (File)
Fri, Mar 29, 2:08 PM
Unknown Object (File)
Mar 17 2024, 2:20 PM
Unknown Object (File)
Mar 6 2024, 7:34 AM
View All 43 Files
Subscribers
sicherha

Details

Reviewers
sicherha
Group Reviewers
PyKolab
PyKolab Developers
Commits
rPe6c4153ac7de: [Python 3] Implicit relative imports fixes

Diff Detail

Repository
rP pykolab
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ghane requested review of this revision.Feb 21 2022, 11:45 PM
ghane created this revision.
ghane mentioned this in T6805: Port pykolab to Python 3.
sicherha requested changes to this revision.Mar 6 2022, 10:18 AM
sicherha subscribed.
sicherha added inline comments.
pykolab/cli/__init__.py
20

This blank line seems to have been added accidentally. Can you drop it?

The rest looks good to me.

This revision now requires changes to proceed.Mar 6 2022, 10:18 AM
ghane updated this revision to Diff 9757.Mar 6 2022, 2:05 PM

removed line at pykolab/cli/__init__.py

ghane marked an inline comment as done.Mar 6 2022, 2:05 PM
sicherha accepted this revision.Mar 6 2022, 2:15 PM

Thanks!

This revision is now accepted and ready to land.Mar 6 2022, 2:15 PM
ghane mentioned this in D3427: [Python 3] relative imports fixes (dynamic imports).Mar 13 2022, 6:57 PM
Closed by commit rPe6c4153ac7de: [Python 3] Implicit relative imports fixes (authored by sicherha). · Explain WhyMar 13 2022, 8:46 PM
This revision was automatically updated to reflect the committed changes.
sicherha mentioned this in rP81921eb1f994: [Python 3] relative imports fixes (dynamic imports).Mar 13 2022, 8:48 PM

Revision Contents
Changeset List

PathSize
pykolab/
3 lines
auth/
ldap/
6 lines
cli/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
imap/
4 lines
setup/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
xml/
58 lines
2 lines
6 lines
wallace/
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 9757

View Options

pykolab/__init__.py

Loading...
View Options

pykolab/auth/ldap/__init__.py

Loading...
View Options

pykolab/cli/__init__.py

Loading...
View Options

pykolab/cli/cmd_acl_cleanup.py

Loading...
View Options

pykolab/cli/cmd_add_alias.py

Loading...
View Options

pykolab/cli/cmd_add_domain.py

Loading...
View Options

pykolab/cli/cmd_add_user.py

Loading...
View Options

pykolab/cli/cmd_add_user_subscription.py

Loading...
View Options

pykolab/cli/cmd_check_quota.py

Loading...
View Options

pykolab/cli/cmd_count_domain_mailboxes.py

Loading...
View Options

pykolab/cli/cmd_create_mailbox.py

Loading...
View Options

pykolab/cli/cmd_delete_domain.py

Loading...
View Options

pykolab/cli/cmd_delete_mailbox.py

Loading...
View Options

pykolab/cli/cmd_delete_mailbox_acl.py

Loading...
View Options

pykolab/cli/cmd_delete_message.py

Loading...
View Options

pykolab/cli/cmd_export_mailbox.py

Loading...
View Options

pykolab/cli/cmd_find_domain.py

Loading...
View Options

pykolab/cli/cmd_list_deleted_mailboxes.py

Loading...
View Options

pykolab/cli/cmd_list_domain_mailboxes.py

Loading...
View Options

pykolab/cli/cmd_list_domains.py

Loading...
View Options

pykolab/cli/cmd_list_mailbox_acls.py

Loading...
View Options

pykolab/cli/cmd_list_mailbox_metadata.py

Loading...
View Options

pykolab/cli/cmd_list_mailboxes.py

Loading...
View Options

pykolab/cli/cmd_list_messages.py

Loading...
View Options

pykolab/cli/cmd_list_ous.py

Loading...
View Options

pykolab/cli/cmd_list_quota.py

Loading...
View Options

pykolab/cli/cmd_list_user_subscriptions.py

Loading...
View Options

pykolab/cli/cmd_list_users.py

Loading...
View Options

pykolab/cli/cmd_mailbox_cleanup.py

Loading...
View Options

pykolab/cli/cmd_remove_mailaddress.py

Loading...
View Options

pykolab/cli/cmd_remove_user_subscription.py

Loading...
View Options

pykolab/cli/cmd_rename_mailbox.py

Loading...
View Options

pykolab/cli/cmd_server_info.py

Loading...
View Options

pykolab/cli/cmd_set_language.py

Loading...
View Options

pykolab/cli/cmd_set_mail.py

Loading...
View Options

pykolab/cli/cmd_set_mailbox_acl.py

Loading...
View Options

pykolab/cli/cmd_set_mailbox_metadata.py

Loading...
View Options

pykolab/cli/cmd_set_quota.py

Loading...
View Options

pykolab/cli/cmd_sync.py

Loading...
View Options

pykolab/cli/cmd_sync_mailhost_attrs.py

Loading...
View Options

pykolab/cli/cmd_transfer_mailbox.py

Loading...
View Options

pykolab/cli/cmd_undelete_mailbox.py

Loading...
View Options

pykolab/cli/cmd_user_info.py

Loading...
View Options

pykolab/imap/__init__.py

Loading...
View Options

pykolab/setup/__init__.py

Loading...
View Options

pykolab/setup/setup_freebusy.py

Loading...
View Options

pykolab/setup/setup_guam.py

Loading...
View Options

pykolab/setup/setup_imap.py

Loading...
View Options

pykolab/setup/setup_kolabd.py

Loading...
View Options

pykolab/setup/setup_ldap.py

Loading...
View Options

pykolab/setup/setup_manticore.py

Loading...
View Options

pykolab/setup/setup_mta.py

Loading...
View Options

pykolab/setup/setup_mysql.py

Loading...
View Options

pykolab/setup/setup_php.py

Loading...
View Options

pykolab/setup/setup_roundcube.py

Loading...
View Options

pykolab/setup/setup_syncroton.py

Loading...
View Options

pykolab/xml/__init__.py

Loading...
View Options

pykolab/xml/attendee.py

Loading...
View Options

pykolab/xml/event.py

Loading...
View Options

wallace/__init__.py

Loading...
View Options

wallace/module_footer.py

Loading...
View Options

wallace/module_gpgencrypt.py

Loading...
View Options

wallace/module_invitationpolicy.py

Loading...
View Options

wallace/module_optout.py

Loading...
View Options

wallace/module_resources.py

Loading...
View Options

wallace/module_signature.py

Loading...