Differential D2026

Check if swoole is installed in quickstart.sh
ClosedPublic
Actions

Authored by mollekopf on Dec 30 2020, 9:41 AM.

Project Tags

None

Referenced Files

	F117752857: D2026.1775191533.diff
	Thu, Apr 2, 4:45 AM

	F117747661: D2026.1775176223.diff
	Thu, Apr 2, 12:30 AM

	F117681360: D2026.1774876294.diff
	Sun, Mar 29, 1:11 PM

	F117350976: D2026.1774811437.diff
	Sat, Mar 28, 7:10 PM

Subscribers

vanmeeuwen

Restricted Project

Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rK388903cf7aca: Check if swoole is installed in quickstart.sh

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Dec 30 2020, 9:41 AM

mollekopf created this revision.

Harbormaster completed remote builds in B32305: Diff 5530.Dec 30 2020, 9:41 AM

mollekopf added a reviewer: Restricted Project.Dec 30 2020, 9:42 AM

mollekopf added a subscriber: Restricted Project.

vanmeeuwen requested changes to this revision.Dec 30 2020, 11:50 AM

vanmeeuwen subscribed.

vanmeeuwen added inline comments.

bin/quickstart.sh
34	Let's use php -m instead.

This revision now requires changes to proceed.Dec 30 2020, 11:50 AM

Only check if the module is available so we don't depend on pecl

Harbormaster completed remote builds in B32329: Diff 5560.Dec 30 2020, 2:40 PM

vanmeeuwen accepted this revision.Dec 31 2020, 10:32 AM

This revision is now accepted and ready to land.Dec 31 2020, 10:32 AM

Closed by commit rK388903cf7aca: Check if swoole is installed in quickstart.sh. · Explain WhyDec 31 2020, 10:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

bin/

quickstart.sh

lines

Diff 5590

View Options

Check if swoole is installed in quickstart.shClosedPublicActions