Page MenuHomekolab.org
Differential D2026

Check if swoole is installed in quickstart.sh
ClosedPublic
Actions

Authored by mollekopf on Dec 30 2020, 10:41 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK388903cf7aca: Check if swoole is installed in quickstart.sh

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Dec 30 2020, 10:41 AM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Dec 30 2020, 10:42 AM
mollekopf added a subscriber: Restricted Project.
vanmeeuwen requested changes to this revision.Dec 30 2020, 12:50 PM
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
bin/quickstart.sh
34

Let's use php -m instead.

This revision now requires changes to proceed.Dec 30 2020, 12:50 PM
mollekopf updated this revision to Diff 5560.Dec 30 2020, 3:40 PM

Only check if the module is available so we don't depend on pecl

vanmeeuwen accepted this revision.Dec 31 2020, 11:32 AM
This revision is now accepted and ready to land.Dec 31 2020, 11:32 AM
Closed by commit rK388903cf7aca: Check if swoole is installed in quickstart.sh (authored by mollekopf, committed by vanmeeuwen). · Explain WhyDec 31 2020, 11:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mbin/quickstart.sh (3 lines)

Diff 5590

View Options

bin/quickstart.sh

Loading...