Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rK935ebfbd0c31: OpenVidu: Room lock

Summary

TODO: Tests

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Dec 4 2020, 10:52 AM

machniak created this revision.

Harbormaster completed remote builds in B32005: Diff 5260.Dec 4 2020, 10:52 AM

Added tests
Added browser tests
Picture format and request id validation

Harbormaster completed remote builds in B32011: Diff 5266.Dec 7 2020, 1:30 PM

Add Room::ROLE_* constants

Harbormaster completed remote builds in B32029: Diff 5284.Dec 8 2020, 11:29 AM

Dismissing participants from the room

Harbormaster completed remote builds in B32041: Diff 5296.Dec 10 2020, 3:11 PM

vanmeeuwen accepted this revision.Dec 16 2020, 8:33 AM

This revision is now accepted and ready to land.Dec 16 2020, 8:33 AM

Closed by commit rK935ebfbd0c31: OpenVidu: Room lock (authored by machniak). · Explain WhyDec 16 2020, 11:33 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/app/Http/Controllers/API/V4/OpenViduController.php (147 lines)
M		src/app/Http/Controllers/Controller.php (7 lines)
M		src/app/OpenVidu/Room.php (189 lines)
A	M	src/resources/images/user.svg (1 line)
M		src/resources/js/meet/app.js (64 lines)
M		src/resources/lang/en/meet.php (5 lines)
M		src/resources/themes/meet.scss (85 lines)
M		src/resources/themes/toast.scss (4 lines)
M		src/resources/vue/Meet/Room.vue (168 lines)
M		src/resources/vue/Meet/SessionSecurityOptions.vue (10 lines)
M		src/resources/vue/Widgets/Toast.vue (10 lines)
M		src/resources/vue/Widgets/ToastMessage.vue (38 lines)
M		src/routes/api.php (4 lines)
M		src/tests/Browser.php (13 lines)
M		src/tests/Browser/Components/Toast.php (1 line)
M		src/tests/Browser/Meet/RoomSecurityTest.php (121 lines)
M		src/tests/Browser/Meet/RoomSetupTest.php (4 lines)
M		src/tests/Feature/Controller/OpenViduTest.php (194 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5260	0794370		Dec 4 2020, 10:52 AM	★	★
Diff 2	5266	0794370	- Added tests	Dec 7 2020, 1:29 PM	★	★
Diff 3	5284	0794370	- Add Room::ROLE_* constants	Dec 8 2020, 11:29 AM	★	★
Diff 4	5296	0794370	- Dismissing participants from the room	Dec 10 2020, 3:10 PM	★	★
Diff 5	5350	39e3642	rK935ebfbd0c311d5fafb9717d5b8da7364782782e	Dec 16 2020, 11:31 AM	★	★

OpenVidu: Room lock
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5350

src/app/Http/Controllers/API/V4/OpenViduController.php

src/app/Http/Controllers/Controller.php

src/app/OpenVidu/Room.php

src/resources/images/user.svg

src/resources/js/meet/app.js

src/resources/lang/en/meet.php

src/resources/themes/meet.scss

src/resources/themes/toast.scss

src/resources/vue/Meet/Room.vue

src/resources/vue/Meet/SessionSecurityOptions.vue

src/resources/vue/Widgets/Toast.vue

src/resources/vue/Widgets/ToastMessage.vue

src/routes/api.php

src/tests/Browser.php

src/tests/Browser/Components/Toast.php

src/tests/Browser/Meet/RoomSecurityTest.php

src/tests/Browser/Meet/RoomSetupTest.php

src/tests/Feature/Controller/OpenViduTest.php

OpenVidu: Room lockClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5350

src/app/Http/Controllers/API/V4/OpenViduController.php

src/app/Http/Controllers/Controller.php

src/app/OpenVidu/Room.php

src/resources/images/user.svg

src/resources/js/meet/app.js

src/resources/lang/en/meet.php

src/resources/themes/meet.scss

src/resources/themes/toast.scss

src/resources/vue/Meet/Room.vue

src/resources/vue/Meet/SessionSecurityOptions.vue

src/resources/vue/Widgets/Toast.vue

src/resources/vue/Widgets/ToastMessage.vue

src/routes/api.php

src/tests/Browser.php

src/tests/Browser/Components/Toast.php

src/tests/Browser/Meet/RoomSecurityTest.php

src/tests/Browser/Meet/RoomSetupTest.php

src/tests/Feature/Controller/OpenViduTest.php

OpenVidu: Room lock
ClosedPublic
Actions

Revision Contents
Changeset List