Page MenuHomekolab.org

Trigger auto-payment immediately after configuration
ClosedPublic

Authored by machniak on Nov 30 2020, 11:29 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK30c257e29316: Trigger auto-payment immediately after configuration
Summary

TODO: The same for Stripe

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Nov 30 2020, 11:29 AM
machniak created this revision.
machniak edited the summary of this revision. (Show Details)Nov 30 2020, 11:46 AM
machniak updated this revision to Diff 5230.Nov 30 2020, 1:05 PM
  • Stripe: Trigger auto-payment immediately after setup
vanmeeuwen requested changes to this revision.Dec 8 2020, 10:17 AM
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
src/app/Http/Controllers/API/V4/PaymentsController.php
62

Let's make this "balance less than or equal to", since users expect their "this account balance lasts you until $date" to change along with the payment setup.

This revision now requires changes to proceed.Dec 8 2020, 10:17 AM
machniak updated this revision to Diff 5290.Dec 9 2020, 9:13 AM
  • De-duplicate mandate input validation code
  • Top up the wallet whn the balance is below the threshold (not 0)
vanmeeuwen accepted this revision.Dec 16 2020, 8:29 AM
This revision is now accepted and ready to land.Dec 16 2020, 8:29 AM
This revision was automatically updated to reflect the committed changes.