Page MenuHomekolab.org

Append signatures from templates using LDAP information and conditionals.
Changes PlannedPublic

Authored by vanmeeuwen on Jun 2 2016, 9:37 AM.

Details

Reviewers
machniak
Group Reviewers
PyKolab Developers
Maniphest Tasks
Restricted Maniphest Task
Summary

Resolves T1279

Add a preliminary module to append signatures generated from templates

Add sample configuration

Test Plan

None

Diff Detail

Repository
rP pykolab
Branch
dev/T1279
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3787
Build 3770: arc lint + arc unit

Event Timeline

vanmeeuwen updated this revision to Diff 368.Jun 2 2016, 9:37 AM
vanmeeuwen retitled this revision from to Append signatures from templates using LDAP information and conditionals..
vanmeeuwen updated this object.
vanmeeuwen edited the test plan for this revision. (Show Details)
vanmeeuwen added a task: Restricted Maniphest Task.
machniak added inline comments.Jun 2 2016, 11:28 AM
wallace/module_signature.py
136

I suppose the file could be read once, not inside the while loop. Also, wouldn't be good to break the for loop on first matching rule?

156

Wouldn't be better to check X-Wallace-Signature header before auth.connect()?

vanmeeuwen planned changes to this revision.Jul 1 2016, 1:05 PM

Please take care to provide the action "request changes" to your comments in order to pop it back over in to my queue.

wallace/module_signature.py
136

The file could be read once.

We could also mandate the first rule matching triggers breaking the loop.

Additionally, we probably should try and retry the while not success try/except infinitely.