Page MenuHomekolab.org

Append signatures from templates using LDAP information and conditionals.
ClosedPublic

Authored by vanmeeuwen on Jun 2 2016, 9:37 AM.

Details

Reviewers
machniak
Group Reviewers
PyKolab Developers
Maniphest Tasks
Restricted Maniphest Task
Commits
rPc85dd2472e3c: Append signatures from files, or templates using LDAP information and…
Summary

Resolves T1279

Add a preliminary module to append signatures generated from templates

Add sample configuration

Test Plan

None

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vanmeeuwen updated this revision to Diff 368.Jun 2 2016, 9:37 AM
vanmeeuwen retitled this revision from to Append signatures from templates using LDAP information and conditionals..
vanmeeuwen updated this object.
vanmeeuwen edited the test plan for this revision. (Show Details)
vanmeeuwen added a task: Restricted Maniphest Task.
machniak added inline comments.Jun 2 2016, 11:28 AM
wallace/module_signature.py
137

I suppose the file could be read once, not inside the while loop. Also, wouldn't be good to break the for loop on first matching rule?

157

Wouldn't be better to check X-Wallace-Signature header before auth.connect()?

vanmeeuwen planned changes to this revision.Jul 1 2016, 1:05 PM

Please take care to provide the action "request changes" to your comments in order to pop it back over in to my queue.

wallace/module_signature.py
137

The file could be read once.

We could also mandate the first rule matching triggers breaking the loop.

Additionally, we probably should try and retry the while not success try/except infinitely.

This revision was not accepted when it landed; it landed in state Changes Planned.Jun 18 2019, 11:23 AM
This revision was automatically updated to reflect the committed changes.