Make sure imaplib exception argument is a string before using split() (#5387)
ClosedPublic
Actions

Authored by machniak on Apr 18 2016, 2:37 PM.

Details

Reviewers

Group Reviewers

Commits

rP7c9eed0e662d: Make sure imaplib exception argument is a string before using split() (#5387)
rPf63162347c6f: Make sure imaplib exception argument is a string before using split() (#5387)

Summary

Looks like imaplib in some conditions can throw exceptions without the message or
the message is not a string. We'll cast to string before using split() to prevent from
"AttributeError: 'int' object has no attribute 'split'" errors.

Diff Detail

Repository

rP pykolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 285.Apr 18 2016, 2:37 PM

machniak retitled this revision from to Make sure imaplib exception argument is a string before using split() (#5387).

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: PyKolab Developers.

vanmeeuwen accepted this revision.May 4 2016, 3:55 PM

vanmeeuwen added a reviewer: vanmeeuwen.

This revision is now accepted and ready to land.May 4 2016, 3:55 PM

Closed by commit rPf63162347c6f: Make sure imaplib exception argument is a string before using split() (#5387) (authored by machniak, committed by vanmeeuwen). · Explain WhyMay 4 2016, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

cyruslib.py

6 lines

Diff 322

View Options

Make sure imaplib exception argument is a string before using split() (#5387)ClosedPublicActions