Page MenuHomekolab.org

Progress changes on to LDAP
ClosedPublic

Authored by vanmeeuwen on Mar 27 2020, 7:31 AM.

Details

Summary

Add user status progression on to LDAP

Apply quota changes to LDAP

Test Plan
$ ./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vanmeeuwen requested review of this revision.Mar 27 2020, 7:31 AM
vanmeeuwen created this revision.
vanmeeuwen updated this revision to Diff 2752.Mar 27 2020, 7:51 AM

Rebase on master

vanmeeuwen updated this revision to Diff 2758.Mar 27 2020, 8:42 AM
  • Add postfix configuration changes to poll for the new status
vanmeeuwen updated this revision to Diff 2767.Mar 27 2020, 9:55 AM
  • Also progress certain roles
vanmeeuwen updated this revision to Diff 2773.Mar 27 2020, 10:53 AM
  • Use the actual hosted root dn
  • Obsolete domain-specific roles
  • Create the base roles
machniak added inline comments.
docker/kolab/utils/21-adjust-postfix-config.sh
13

I guess we should use .803 matches here.

src/app/Backends/LDAP.php
307

missing $ldap->close();

386

You could use $user->entitlements() here.

src/app/Console/Commands/DomainCheck.php
40 ↗(On Diff #2767)

Not implemented.

src/app/Console/Commands/DomainList.php
42

You could add ->orderBy('namespace')

src/app/Console/Commands/UserStatus.php
42

At some point we should make these work also with IDs.

vanmeeuwen updated this revision to Diff 2824.Mar 30 2020, 8:15 AM
  • Update for review
vanmeeuwen marked 5 inline comments as done.Mar 30 2020, 8:17 AM
vanmeeuwen updated this revision to Diff 2860.Mar 31 2020, 9:00 AM
  • Rebase on master
machniak accepted this revision.Mar 31 2020, 1:38 PM
This revision is now accepted and ready to land.Mar 31 2020, 1:38 PM
This revision was automatically updated to reflect the committed changes.