Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rK29050daa3be7: Progress changes on to LDAP
rK92ad1510366a: Progress changes on to LDAP

Summary

Add user status progression on to LDAP

Apply quota changes to LDAP

Test Plan

$ ./phpunit

Diff Detail

Repository

rK kolab

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vanmeeuwen requested review of this revision.Mar 27 2020, 7:31 AM

vanmeeuwen created this revision.

Harbormaster completed remote builds in B28753: Diff 2746.Mar 27 2020, 7:31 AM

Rebase on master

Harbormaster completed remote builds in B28765: Diff 2752.Mar 27 2020, 7:51 AM

Add postfix configuration changes to poll for the new status

Harbormaster completed remote builds in B28771: Diff 2758.Mar 27 2020, 8:42 AM

Also progress certain roles

Harbormaster completed remote builds in B28777: Diff 2767.Mar 27 2020, 9:55 AM

Use the actual hosted root dn
Obsolete domain-specific roles
Create the base roles

Harbormaster completed remote builds in B28783: Diff 2773.Mar 27 2020, 10:53 AM

machniak added a subscriber: machniak.Mar 27 2020, 11:01 AM

machniak added inline comments.

docker/kolab/utils/21-adjust-postfix-config.sh
13	I guess we should use .803 matches here.
src/app/Backends/LDAP.php
307	missing $ldap->close();
386	You could use $user->entitlements() here.
src/app/Console/Commands/DomainCheck.php
40 ↗	(On Diff #2767)	Not implemented.
src/app/Console/Commands/DomainList.php
42	You could add ->orderBy('namespace')
src/app/Console/Commands/UserStatus.php
42	At some point we should make these work also with IDs.

Update for review

Harbormaster completed remote builds in B28843: Diff 2824.Mar 30 2020, 8:15 AM

vanmeeuwen marked 5 inline comments as done.Mar 30 2020, 8:17 AM

Rebase on master

Harbormaster completed remote builds in B28888: Diff 2860.Mar 31 2020, 9:00 AM

machniak accepted this revision.Mar 31 2020, 1:38 PM

This revision is now accepted and ready to land.Mar 31 2020, 1:38 PM

Closed by commit rK29050daa3be7: Progress changes on to LDAP (authored by vanmeeuwen). · Explain WhyMar 31 2020, 1:39 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		docker/kolab/kolab-init.sh (1 line)
M		docker/kolab/utils/15-create-hosted-domain.sh (12 lines)
A	M	docker/kolab/utils/21-adjust-postfix-config.sh (26 lines)
M		src/app/Backends/LDAP.php (182 lines)
A	M	src/app/Console/Commands/DomainList.php (47 lines)
A	M	src/app/Console/Commands/DomainStatus.php (51 lines)
A	M	src/app/Console/Commands/DomainSuspend.php (51 lines)
A	M	src/app/Console/Commands/DomainUnsuspend.php (51 lines)
A	M	src/app/Console/Commands/UserStatus.php (51 lines)
A	M	src/app/Console/Commands/UserSuspend.php (51 lines)
A	M	src/app/Console/Commands/UserUnsuspend.php (51 lines)
A	M	src/app/Console/Commands/UserVerify.php (51 lines)
M		src/app/Domain.php (30 lines)
A	M	src/app/Jobs/DomainUpdate.php (44 lines)
M		src/app/Observers/DomainObserver.php (3 lines)
M		src/app/Observers/EntitlementObserver.php (9 lines)
M		src/app/User.php (30 lines)
M		src/database/seeds/UserSeeder.php (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2746	a02286e		Mar 27 2020, 7:31 AM	★	★
Diff 2	2752	5496d31	Rebase on master	Mar 27 2020, 7:51 AM	★	★
Diff 3	2758	5496d31	- Add postfix configuration changes to poll for the new status	Mar 27 2020, 8:42 AM	★	★
Diff 4	2767	5496d31	- Also progress certain roles	Mar 27 2020, 9:55 AM	★	★
Diff 5	2773	5496d31	- Use the actual hosted root dn	Mar 27 2020, 10:53 AM	★	★
Diff 6	2824	5496d31	- Update for review	Mar 30 2020, 8:15 AM	★	★
Diff 7	2860	4ea6222	- Rebase on master	Mar 31 2020, 9:00 AM	★	★
Diff 8	2872	4ea6222	rK29050daa3be73d67a3fc845fd8ce5796cc9c85e7	Mar 31 2020, 1:38 PM	★	★

Progress changes on to LDAP
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2872

docker/kolab/kolab-init.sh

docker/kolab/utils/15-create-hosted-domain.sh

docker/kolab/utils/21-adjust-postfix-config.sh

src/app/Backends/LDAP.php

src/app/Console/Commands/DomainList.php

src/app/Console/Commands/DomainStatus.php

src/app/Console/Commands/DomainSuspend.php

src/app/Console/Commands/DomainUnsuspend.php

src/app/Console/Commands/UserStatus.php

src/app/Console/Commands/UserSuspend.php

src/app/Console/Commands/UserUnsuspend.php

src/app/Console/Commands/UserVerify.php

src/app/Domain.php

src/app/Jobs/DomainUpdate.php

src/app/Observers/DomainObserver.php

src/app/Observers/EntitlementObserver.php

src/app/User.php

src/database/seeds/UserSeeder.php

Progress changes on to LDAPClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2872

docker/kolab/kolab-init.sh

docker/kolab/utils/15-create-hosted-domain.sh

docker/kolab/utils/21-adjust-postfix-config.sh

src/app/Backends/LDAP.php

src/app/Console/Commands/DomainList.php

src/app/Console/Commands/DomainStatus.php

src/app/Console/Commands/DomainSuspend.php

src/app/Console/Commands/DomainUnsuspend.php

src/app/Console/Commands/UserStatus.php

src/app/Console/Commands/UserSuspend.php

src/app/Console/Commands/UserUnsuspend.php

src/app/Console/Commands/UserVerify.php

src/app/Domain.php

src/app/Jobs/DomainUpdate.php

src/app/Observers/DomainObserver.php

src/app/Observers/EntitlementObserver.php

src/app/User.php

src/database/seeds/UserSeeder.php

Progress changes on to LDAP
ClosedPublic
Actions

Revision Contents
Changeset List