Page MenuHomePhorge
Differential D101

Complete the peer review section on actually reviewing differentials, and landing them.
ClosedPublic
Actions

Authored by vanmeeuwen on Mar 14 2016, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 1:24 AM
Unknown Object (File)
Thu, Nov 28, 12:43 AM
Unknown Object (File)
Fri, Nov 22, 5:09 AM
Unknown Object (File)
Fri, Nov 22, 5:09 AM
Unknown Object (File)
Fri, Nov 22, 5:08 AM
Unknown Object (File)
Fri, Nov 22, 5:00 AM
Unknown Object (File)
Thu, Nov 14, 3:32 AM
Unknown Object (File)
Oct 20 2024, 5:26 PM
View All Files
Subscribers
petersen
Tokens
"Like" token, awarded by petersen.

Details

Reviewers
petersen
Group Reviewers
Documentation Authors
Maniphest Tasks
T1095: Mandatory Peer Review Process
Commits
rDd5fbb58d877d: Complete the peer review section on actually reviewing differentials, and…
Summary

Resolves T1095

Test Plan

Read through it.

Diff Detail

Repository
rD docs
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3142
Build 3116: arc lint + arc unit

Event Timeline

vanmeeuwen updated this revision to Diff 214.Mar 14 2016, 3:47 PM
vanmeeuwen retitled this revision from to Complete the peer review section on actually reviewing differentials, and landing them..
vanmeeuwen updated this object.
vanmeeuwen edited the test plan for this revision. (Show Details)
vanmeeuwen added a reviewer: Documentation Authors.
vanmeeuwen added a task: T1095: Mandatory Peer Review Process.
petersen accepted this revision.Mar 24 2016, 12:17 PM
petersen added a reviewer: petersen.
petersen subscribed.

Love all the congratulations. we need more of that.. :-)

This revision is now accepted and ready to land.Mar 24 2016, 12:17 PM
petersen awarded a token.Apr 2 2016, 12:03 PM

It's a go from my perspective. I don't seem to be able to approve it?

Closed by commit rDd5fbb58d877d: Complete the peer review section on actually reviewing differentials, and… (authored by vanmeeuwen, committed by vanmeeuwen). · Explain WhyApr 4 2016, 9:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
contributor-guide/
56 lines

Diff 214

View Options

source/contributor-guide/peer-review.rst

Loading...