Page MenuHomekolab.org

Get rid of owner_id
ClosedPublic

Authored by machniak on Mar 13 2020, 1:28 PM.

Details

Summary

Removed entitlements.owner_id column and Entitlement::owner()

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Mar 13 2020, 1:28 PM
machniak created this revision.
vanmeeuwen requested changes to this revision.Mar 13 2020, 1:46 PM
vanmeeuwen added inline comments.
src/app/Entitlement.php
74–76

I think the function owner() may be preserved yet changed, similar to how App\Domain::wallet() chases the domain through the entitlement to a wallet.

This revision now requires changes to proceed.Mar 13 2020, 1:46 PM
machniak added inline comments.Mar 13 2020, 2:15 PM
src/app/Entitlement.php
74–76

I don't want to make it that simple, so we push ourselvs to think wallets not owners. There's really no need to have it as it would simply be $this->wallet()->owner.

vanmeeuwen accepted this revision.Mar 13 2020, 3:01 PM
This revision is now accepted and ready to land.Mar 13 2020, 3:01 PM
This revision was automatically updated to reflect the committed changes.