Page MenuHomePhorge

Get rid of owner_id
ClosedPublic

Authored by machniak on Mar 13 2020, 1:28 PM.
Tags
None
Referenced Files
F11591523: D1018.diff
Fri, Mar 29, 5:40 AM
Unknown Object (File)
Thu, Mar 28, 3:30 AM
Unknown Object (File)
Feb 25 2024, 8:01 AM
Unknown Object (File)
Jan 19 2024, 5:09 PM
Unknown Object (File)
Jan 19 2024, 9:34 AM
Unknown Object (File)
Jan 19 2024, 8:58 AM
Unknown Object (File)
Jan 9 2024, 12:57 AM
Unknown Object (File)
Jan 8 2024, 11:27 AM
Subscribers
None

Details

Summary

Removed entitlements.owner_id column and Entitlement::owner()

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
vanmeeuwen added inline comments.
src/app/Entitlement.php
74โ€“76

I think the function owner() may be preserved yet changed, similar to how App\Domain::wallet() chases the domain through the entitlement to a wallet.

This revision now requires changes to proceed.Mar 13 2020, 1:46 PM
src/app/Entitlement.php
74โ€“76

I don't want to make it that simple, so we push ourselvs to think wallets not owners. There's really no need to have it as it would simply be $this->wallet()->owner.

This revision is now accepted and ready to land.Mar 13 2020, 3:01 PM
This revision was automatically updated to reflect the committed changes.