HomePhorge

set MAX_PACKET_LEN to 8192 to workaround two bugs:
5f08b9e176ceUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

set MAX_PACKET_LEN to 8192 to workaround two bugs:

  1. nntp: if a line is longer than MAX_PACKET_LEN the rest isn't read
  2. TCPSlaveBase::readLine(): in that case -1 is returned as QIODevice::readLine() reads only maxSize - 1 (one byte less for terminating '\0') and TCPSlaveBase::readLine() calls QIODevice::readLine() for one byte, but QIODevice::readLine() needs at least 2.

CCMAIL:vkrause@kde.org
CCMAIL:ahartmetz@gmail.com

Volker, Andreas, is memset() really needed before calling TCPSlaveBase::readLine()?

Andreas, could you please extent the docu of TCPSlaveBase::readLine() (e.g. what happens
if the line is longer than len).

svn path=/branches/KDE/4.2/kdepimlibs/; revision=909480

Details

Provenance
André Wöbbeking <woebbeking@kde.org>Authored on
Parents
rKPL54626829bbd3: Backport of r909374
Branches
Unknown
Tags
Unknown

Event Timeline

André Wöbbeking <woebbeking@kde.org> committed rKPL5f08b9e176ce: set MAX_PACKET_LEN to 8192 to workaround two bugs: (authored by André Wöbbeking <woebbeking@kde.org>).Jan 11 2009, 6:35 PM