Project Tags

None

Referenced Files

None

Subscribers

Restricted Project

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rKbf1da85cbea7: Device signup improvements and fixes

Summary

On token signup auto-claim the device
Fix claiming a non-existing device
More tests and a fix

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/device-signup

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 55566
Build 19716: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 29 2025, 2:20 PM

machniak created this revision.

Harbormaster completed remote builds in B55539: Diff 16197.Sep 29 2025, 2:20 PM

Remove TODO comment

Harbormaster completed remote builds in B55566: Diff 16200.Sep 30 2025, 9:19 AM

Add freeMonths to the device info response
Add device info to signup/claim responses

Harbormaster completed remote builds in B55578: Diff 16206.Oct 1 2025, 12:50 PM

Make 'plan' parameter optional on signup with a device token

Harbormaster completed remote builds in B55581: Diff 16209.Oct 1 2025, 2:05 PM

Include Plan ID in user info and plan responses
Unify verification code validation code
Add option to set short code value for all new verification codes

Harbormaster completed remote builds in B55584: Diff 16212.Oct 2 2025, 7:51 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2025, 6:48 AM

Closed by commit rKbf1da85cbea7: Device signup improvements and fixes. · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rKbf1da85cbea7: Device signup improvements and fixes.

Device signup improvements and fixes
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16200

src/app/Device.php

src/app/Http/Controllers/API/SignupController.php

src/app/Http/Controllers/API/V4/DeviceController.php

src/app/Plan.php

src/tests/Feature/Controller/DeviceTest.php

src/tests/Feature/Controller/SignupTest.php

src/tests/Feature/PlanTest.php

Device signup improvements and fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16200

src/app/Device.php

src/app/Http/Controllers/API/SignupController.php

src/app/Http/Controllers/API/V4/DeviceController.php

src/app/Plan.php

src/tests/Feature/Controller/DeviceTest.php

src/tests/Feature/Controller/SignupTest.php

src/tests/Feature/PlanTest.php

Device signup improvements and fixes
ClosedPublic
Actions

Revision Contents
Changeset List