ACL management for DAV folders
ClosedPublic
Actions

Authored by machniak on Mar 18 2024, 5:53 PM.

Details

Reviewers

None

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPK578617215494: ACL management for DAV folders
rRPKbe6eaf682407: ACL management for DAV folders

Summary

Implement DAV folder sharing based on draft-pot-webdav-resource-sharing standard

We keep the DAV ACL standard implementation as an option, but this standard
does not cover the folder discovery, so we'll not use it with Kolab setups.

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Branch

dev/dav

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 46896
Build 17916: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Mar 18 2024, 5:53 PM

machniak created this revision.

Harbormaster completed remote builds in B46806: Diff 13428.Mar 18 2024, 5:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2024, 9:59 PM

Closed by commit rRPKbe6eaf682407: ACL management for DAV folders. · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rRPKbe6eaf682407: ACL management for DAV folders.

machniak reopened this revision.Mar 27 2024, 1:46 PM

DAV share invitations for addressbooks, calendars and tasklists

Harbormaster completed remote builds in B46896: Diff 13446.Mar 27 2024, 1:46 PM

Enable user autocomplete in DAV sharing

Harbormaster completed remote builds in B46902: Diff 13452.Mar 28 2024, 3:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2024, 3:46 PM

Closed by commit rRPK578617215494: ACL management for DAV folders. · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rRPK578617215494: ACL management for DAV folders.

Revision Contents
Changeset List

Path

Size

.gitignore

10 lines

plugins/

calendar/

calendar.php

17 lines

calendar_ui.js

2 lines

drivers/

caldav/

caldav_calendar.php

17 lines

caldav_driver.php

239 lines

calendar_driver.php

12 lines

database/

database_driver.php

2 lines

lib/

calendar_ui.php

22 lines

kolab_addressbook/

drivers/

carddav/

carddav_contacts.php

16 lines

carddav_contacts_driver.php

99 lines

kolab/

kolab_contacts_driver.php

108 lines

kolab_addressbook.js

7 lines

kolab_addressbook.php

122 lines

libkolab/

config.inc.php.dist

6 lines

lib/

kolab_dav_acl.php

543 lines

kolab_dav_client.php

515 lines

kolab_dav_sharing.php

473 lines

kolab_storage_dav.php

120 lines

kolab_storage_dav_folder.php

246 lines

kolab_utils.php

52 lines

libkolab.js

415 lines

libkolab.php

10 lines

localization/

en_US.inc

32 lines

skins/

elastic/

templates/

acl.html

33 lines

larry/

images/

enabled.png

partial.png

libkolab.css

101 lines

templates/

acl.html

27 lines

tests/

LibkolabTest.php

76 lines

tasklist/

drivers/

caldav/

tasklist_caldav_driver.php

109 lines

12 lines

3 lines

14 lines

40 lines

Diff 13446

View Options

.gitignore

	*.tar.gz			*.tar.gz
	*.tar.gz.gpg			*.tar.gz.gpg
	*.patch			*.patch
	.phpunit.result.cache			.phpunit.result.cache
	plugins/*/config.inc.php			./plugins/*/config.inc.php
	program			./program
	skins			./skins
	tests			./tests
	vendor			./vendor

View Options

plugins/calendar/calendar.php

View Options

plugins/calendar/calendar_ui.js

Show First 20 Lines • Show All 3,566 Lines • ▼ Show 20 Lines	calendars_list = new widget_class(rcmail.gui_objects.calendarslist, {
search_action: 'calendar/calendar',		search_action: 'calendar/calendar',
search_sources: [ 'folders', 'users' ],		search_sources: [ 'folders', 'users' ],
search_title: rcmail.gettext('calsearchresults','calendar')		search_title: rcmail.gettext('calsearchresults','calendar')
});		});
calendars_list.addEventListener('select', function(node) {		calendars_list.addEventListener('select', function(node) {
if (node && node.id && me.calendars[node.id]) {		if (node && node.id && me.calendars[node.id]) {
me.select_calendar(node.id, true);		me.select_calendar(node.id, true);
rcmail.enable_command('calendar-edit', 'calendar-showurl', 'calendar-showfburl', true);		rcmail.enable_command('calendar-edit', 'calendar-showurl', 'calendar-showfburl', true);
rcmail.enable_command('calendar-delete', me.calendars[node.id].editable);		rcmail.enable_command('calendar-delete', me.has_permission(me.calendars[node.id], 'xa'));
rcmail.enable_command('calendar-remove', me.calendars[node.id] && me.calendars[node.id].removable);		rcmail.enable_command('calendar-remove', me.calendars[node.id] && me.calendars[node.id].removable);
}		}
});		});
calendars_list.addEventListener('insert-item', function(p) {		calendars_list.addEventListener('insert-item', function(p) {
var cal = p.data;		var cal = p.data;
if (cal && cal.id) {		if (cal && cal.id) {
add_calendar_source(cal);		add_calendar_source(cal);

▲ Show 20 Lines • Show All 756 Lines • Show Last 20 Lines

View Options

plugins/calendar/drivers/caldav/caldav_calendar.php

Show All 24 Lines
{		{
public $ready = false;		public $ready = false;
public $rights = 'lrs';		public $rights = 'lrs';
public $editable = false;		public $editable = false;
public $attachments = true;		public $attachments = true;
public $alarms = false;		public $alarms = false;
public $history = false;		public $history = false;
public $subscriptions = false;		public $subscriptions = false;
		public $share_invitation = null;
public $categories = [];		public $categories = [];
public $storage;		public $storage;

public $type = 'event';		public $type = 'event';

protected $cal;		protected $cal;
protected $events = [];		protected $events = [];
protected $search_fields = ['title', 'description', 'location', 'attendees', 'categories'];		protected $search_fields = ['title', 'description', 'location', 'attendees', 'categories'];
Show All 29 Lines	public function __construct($folder_or_id, $calendar)
if ($this->ready) {		if ($this->ready) {
$this->id = $this->storage->id;		$this->id = $this->storage->id;
$this->attributes = $this->storage->attributes;		$this->attributes = $this->storage->attributes;
$this->default = $this->storage->default;		$this->default = $this->storage->default;
$this->subtype = $this->storage->subtype;		$this->subtype = $this->storage->subtype;
$this->alarms = !isset($this->attributes['alarms']) \|\| $this->attributes['alarms'];		$this->alarms = !isset($this->attributes['alarms']) \|\| $this->attributes['alarms'];

if ($this->storage->get_namespace() == 'personal') {		if ($this->storage->get_namespace() == 'personal') {
$this->editable = true;
$this->rights = 'lrswikxteav';		$this->rights = 'lrswikxteav';
} else {		} else {
$rights = $this->storage->get_myrights();		$this->rights = $this->storage->get_myrights();
if ($rights) {
$this->rights = $rights;
if (strpos($rights, 't') !== false \|\| strpos($rights, 'd') !== false) {
$this->editable = strpos($rights, 'i');
;
}
}		}

		$this->editable = strpos($this->rights, 'i') !== false;

		if (!empty($this->attributes['invitation'])) {
		$this->share_invitation = $this->attributes['invitation'];
}		}
}		}
}		}

/**		/**
* Getter for the folder name		* Getter for the folder name
*		*
* @return string Name of the folder		* @return string Name of the folder
▲ Show 20 Lines • Show All 783 Lines • Show Last 20 Lines