Page MenuHomePhorge

PHP warnings
Closed, ResolvedPublic

Description

Hi all,

Running the latest git version of the roundcubemail plugins with roundcubemail 1.5.0 and getting warnings in roundcubemail logging. I would like to propose some fixes for these.

libcalendaring/libcalendaring.php on line 856
Testing if array key exists needs implicant testing in php 8.
Proposal: $output = sprintf('%s %d ', $this->gettext('every'), isset($rrule['INTERVAL']) ? $rrule['INTERVAL'] : 1);

calendar/drivers/calendar_driver.php on line 793
Creation of dynamic property DateTime::$_dateonly is deprecated
Proposal: remove line: $bday->_dateonly = true;

calendar/calendar.php on line 2118
PHP Warning Undefined array key "attendees"
Proposal: wrap foreach in if(isset($event['attendees'])){

calendar/drivers/calendar_driver.php on line 650
PHP Warning PHP Deprecated: mb_strtolower(): Passing null to parameter #1
Proposal: if(isset($search)) $search = mb_strtolower($search);

Details

Ticket Type
Task

Event Timeline

plugins/calendar/drivers/calendar_driver.php on line 510
Undefined $exception
Proposal: $next_event['id'] = $next_event['uid'] . '-' . $next_event['_instance'];

machniak claimed this task.
machniak subscribed.

Fixed in git-master.