Maniphest T1098

BC break in kolab_storage_folder::get_object()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	machniak
	Mar 7 2016, 4:49 PM

Tags

Referenced Files

None

Subscribers

Description

I noticed that in Winterfell I can't syncronize any contacts. The reason is that second argument of get_object() call in https://git.kolab.org/diffusion/I/browse/master/lib/Kolab/CardDAV/ContactsBackend.php;29c94376d9a09ddcf11387d46077511e5aa9ab7d$352 is not handled properly, i.e. it creates "type = '*'" check in the SQL query, which is wrong. Not sure yet when it broke.

Details

Ticket Type: Task

Related Objects

Mentioned In: rRPK9daf32495a7a: Fix regression in get_object() (T1098)

Event Timeline

machniak created this task.Mar 7 2016, 4:49 PM

This broke in my recent performance improvements in libkolab plugin code. https://git.kolab.org/rRPK52053f355af6c09db547f1b8d02bb9ae88abcb1c So, it's Winterfell only.

machniak renamed this task from CardDAV does not work to BC break in kolab_storage_folder::get_object().Mar 7 2016, 5:03 PM

machniak edited projects, added Roundcube Kolab Plugins ; removed iRony.

machniak claimed this task.Mar 7 2016, 5:13 PM

machniak mentioned this in rRPK9daf32495a7a: Fix regression in get_object() (T1098).Mar 7 2016, 5:55 PM

machniak closed this task as Resolved.Mar 7 2016, 5:55 PM