Page MenuHomekolab.org

improve calendar editor
Needs ReviewPublic

Authored by bohlender on Aug 8 2019, 8:26 AM.

Details

Reviewers
machniak
Summary


Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

bohlender requested review of this revision.Aug 8 2019, 8:26 AM
bohlender created this revision.
bohlender updated this revision to Diff 1805.EditedAug 8 2019, 10:17 AM

now without the spaces

bohlender updated this revision to Diff 1811.Aug 9 2019, 1:51 PM

now with icon

bohlender edited the summary of this revision. (Show Details)Aug 9 2019, 1:52 PM
bohlender edited the summary of this revision. (Show Details)

@machniak: not sure how to handle translateable strings.

  • Do I need to do more to add a new one than adding it to the en_US version?
  • should I remove the obsolete $labels['tabattachments'] = 'Attachments'; from all files in localization ?

There's already "More" label in Roundcube core. So, you can just use 'more' instead of 'calendar.tabmore' in the template.