Let iRony handle AD date-time format
ClosedPublic
Actions

Authored by fjl on Sep 17 2018, 10:03 AM.

Details

Reviewers

machniak

Group Reviewers

iRony Developers

Summary

Samba 4 LDAP (or MS AD) use a date-time format like whenChanged: 20180514062231.0Z. This is the ASN.1 Generalized-Time format which translates to 2018-05-14T06:22:31

Diff Detail

Repository

rI iRony

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fjl created this revision.Sep 17 2018, 10:03 AM

fjl updated this revision to Diff 1550.Sep 17 2018, 10:21 AM

fjl added a reviewer: iRony Developers.Sep 17 2018, 10:41 AM

machniak accepted this revision.Sep 3 2020, 8:42 AM

This revision is now accepted and ready to land.Sep 3 2020, 8:42 AM

I'm unable to arc patch your differential. It's because somehow you used .orig files. Either fix it or tell me what author (email and name) I should use for the manual commit.

This revision now requires changes to proceed.Sep 3 2020, 10:41 AM

Having no prior experience at all with Phabricator, I unfortunately have no idea what kind patch formatting Differential expects. We're adding diffs using plain patch command which has no issues with referring to *.orig. So it would be great if you could do a manual commit. Thank you!

Achim Leitner
aleitner@lis-engineering.de

machniak mentioned this in rI4a21dcf23c7f: D674: Let iRony handle AD date-time format.Sep 4 2020, 9:14 AM

machniak accepted this revision.Sep 4 2020, 9:15 AM

This revision is now accepted and ready to land.Sep 4 2020, 9:15 AM

Merged.

Revision Contents
Changeset List

Path

Size

lib/

Kolab/

CardDAV/

	LDAPDirectory.php
	LDAPDirectory.php.orig

2 lines

Diff 1550

View Options

lib/Kolab/CardDAV/LDAPDirectory.php

Let iRony handle AD date-time formatClosedPublicActions