Let iRony handle AD date-time format

Authored by fjl on Sep 17 2018, 10:03 AM.


Group Reviewers
iRony Developers

Samba 4 LDAP (or MS AD) use a date-time format like whenChanged: 20180514062231.0Z. This is the ASN.1 Generalized-Time format which translates to 2018-05-14T06:22:31

Diff Detail

rI iRony
Lint Skipped
Unit Tests Skipped

Event Timeline

fjl created this revision.Sep 17 2018, 10:03 AM
fjl updated this revision to Diff 1550.Sep 17 2018, 10:21 AM
machniak accepted this revision.Sep 3 2020, 8:42 AM
This revision is now accepted and ready to land.Sep 3 2020, 8:42 AM
machniak requested changes to this revision.Sep 3 2020, 10:41 AM

I'm unable to arc patch your differential. It's because somehow you used .orig files. Either fix it or tell me what author (email and name) I should use for the manual commit.

This revision now requires changes to proceed.Sep 3 2020, 10:41 AM
fjl added a comment.Sep 4 2020, 8:29 AM

Having no prior experience at all with Phabricator, I unfortunately have no idea what kind patch formatting Differential expects. We're adding diffs using plain patch command which has no issues with referring to *.orig. So it would be great if you could do a manual commit. Thank you!

  • Achim Leitner
machniak accepted this revision.Sep 4 2020, 9:15 AM
This revision is now accepted and ready to land.Sep 4 2020, 9:15 AM
machniak closed this revision.Sep 4 2020, 9:15 AM