Page MenuHomePhorge

A task print widget
ClosedPublic

Authored by knauss on Sep 25 2015, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 8:17 PM
Unknown Object (File)
Tue, Jun 11, 3:41 AM
Unknown Object (File)
Wed, Jun 5, 5:54 PM
Unknown Object (File)
Thu, May 30, 5:14 PM
Unknown Object (File)
Thu, May 30, 5:14 PM
Unknown Object (File)
Thu, May 30, 5:14 PM
Unknown Object (File)
Thu, May 30, 5:14 PM
Unknown Object (File)
Thu, May 30, 5:05 PM
Subscribers
None

Details

Reviewers
mollekopf
Maniphest Tasks
Restricted Maniphest Task
Summary

this is only a first try to create a html output of the task list, for
printing.

Diff Detail

Repository
rZ zanshin
Branch
dev/print
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

knauss retitled this revision from to A task print widget.
knauss updated this object.
knauss added a reviewer: mollekopf.
knauss added a task: Restricted Maniphest Task.

christian: if you have any good intput in the topics, please add them

src/widgets/printwidget.cpp
55

is there a signal of the model, that it has now loaded all tasks? Or is there only live models?

62

here we would select the tasks to print, so add proxymodels etc. on top to have the correct selection.

94

no way, we need any kind of templete engine, otherwise we get awfull code too

Will have a look into grantlee.

src/widgets/printwidget.cpp
55

You can insert a "doneHandler" for that purpose.

62

If we can reuse the model that is displayed, we make sure we always print exactly what is displayed.

94

it's not a big deal if we have a single function that does a bunch of html assembling... As long as it doesn't evolve into thousands of lines of html assembling code.

  • Grantlee support for printing
  • use pageview model
  • add i18n support for grantlee
  • add print menu
src/presentation/tasklistmodel.h
57 ↗(On Diff #114)

no more needed anymore. can be removed again.

src/widgets/CMakeLists.txt
34–36

install the templates, too.

src/widgets/grantlee_paths.h.cmake
3

src/widget/templates is that a good place for the templates

src/widgets/pageview.cpp
159–161

should the print action be removed in the context menu?

src/widgets/grantlee_paths.h.cmake
3

I guess so, it's presentation after all.

src/widgets/pageview.cpp
159–161

I think so, unless we want to be able to print specific single tasks. But that's another milestone.

src/widgets/pageview.cpp
159–161

well at the moment the print is only shon in context menu, if it is not the context menu of one task. So in logic it is correct, to print the list via context menu.

does it close all tasks now?

mollekopf edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 12:39 PM