The only rfc822 function used below is rfc822.parsedate(); according to https://docs.python.org/3.10/library/email.utils.html, its email counterpart is not not email.parsedate() but email.utils.parsedate().

Since the email.utils module is already available in Python 2.7, I suggest the following:

In line 22, change import rfc822 to import email.utils
In line 199, change the call to rfc822.parsedate() to email.utils.parsedate()

This revision now requires changes to proceed.Mar 15 2022, 12:10 AM

I'll just change line 22

import email.utils as rfc822

this keeps the history and intention of the code alive.

sicherha accepted this revision.Mar 16 2022, 10:22 PM

This revision is now accepted and ready to land.Mar 16 2022, 10:22 PM

Closed by commit rPb7a9a386bb97: [Python 3]rfc822 module has been removed (authored by sicherha). · Explain WhyMar 16 2022, 10:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

pykolab/

telemetry.py

2 lines

Diff 9892

View Options

[Python 3]rfc822 module has been removedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9892

pykolab/telemetry.py

[Python 3]rfc822 module has been removed
ClosedPublic
Actions

Revision Contents
Changeset List