python 2.7 -3 ./kolab-cli.py -d 9 lm
DeprecationWarning: in 3.x, rfc822 has been removed in favor of the email package
Details
Details
- Reviewers
sicherha - Group Reviewers
PyKolab Developers - Commits
- rPb7a9a386bb97: [Python 3]rfc822 module has been removed
Diff Detail
Diff Detail
- Repository
- rP pykolab
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
The only rfc822 function used below is rfc822.parsedate(); according to https://docs.python.org/3.10/library/email.utils.html, its email counterpart is not not email.parsedate() but email.utils.parsedate().
Since the email.utils module is already available in Python 2.7, I suggest the following:
- In line 22, change import rfc822 to import email.utils
- In line 199, change the call to rfc822.parsedate() to email.utils.parsedate()
Comment Actions
I'll just change line 22
import email.utils as rfc822
this keeps the history and intention of the code alive.