With small code refactoring and switch to MySQL.
Details
Details
- Reviewers
- None
- Group Reviewers
Kolab Chat Developers - Commits
- rKC5f7567755e6a: Store users in database
Diff Detail
Diff Detail
- Repository
- rKC kolab-chat
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This will be used to store user auth tokens, e.g. to validate sessions? If so, should this use Phoenix.Token instead (https://hexdocs.pm/phoenix/Phoenix.Token.html)? Auth will be served by Kolab (e.g. LDAP), and presence managed by Pheonix Presence .... ?
| priv/repo/migrations/20161213091438_add_users.exs | ||
|---|---|---|
| 8 | what will status be used for? | |
Comment Actions
I'm working on websockets and tokens (yes, Phoenix.Token). So, this diff only stores users in database to have user ID. Status is for user status in future (but I suppose we'll change that to some another database table). I didn't think about Phoenix.Presence yet.
Comment Actions
Ah, yes, phoenix presence handles their status entirely. We need to do nothing for that (and should not .. it's a complicated thing, and they have implemented it fully).
If the table is just for user id, I can see how that is useful in the short term. Long-term, I suspect this will go away, when we are able to authenticate against Kolab itself. So .. minus status, and otherwise OK for moving things forward ... :)