wait until we have at least a tag+command for filtering to commence
ClosedPublic
Actions

Authored by • seigo on Sep 7 2016, 10:01 AM.

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rG471f90819ea1: Merge branch 'feature/support_tag_arrives_before_command' into develop
rGb1552bcf1e3a: wait until we have at least a tag+command for filtering to commence

Summary

This attempts to work around the interesting behavior seen with iPhones doing
TLS where the tag of the command is sent in a network packet on its own separate from
the command string.

Diff Detail

Repository

rG guam

Branch

feature/support_tag_arrives_before_command

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4607
Build 4608: arc lint + arc unit

Event Timeline

• seigo updated this revision to Diff 463.Sep 7 2016, 10:01 AM

• seigo retitled this revision from to wait until we have at least a tag+command for filtering to commence.

• seigo updated this object.

• seigo edited the test plan for this revision. (Show Details)

• seigo added a reviewer: Restricted Project.

Note that only very nominal testing has been done thus far, but I wanted to give others a preview look at what is cooking here.

This also brings a nice little optimization where commands are split into tag/command/data only *once* instead of at least twice per client-side rule application (something that would get even worse as the number of rues grows ...)

• seigo mentioned this in T1486: Guam session process command only once tag+command recv'd from client.Sep 12 2016, 10:03 AM

Closed by commit rGb1552bcf1e3a: wait until we have at least a tag+command for filtering to commence (authored by • seigo, committed by • seigo). · Explain WhySep 19 2016, 1:33 PM

This revision was automatically updated to reflect the committed changes.

• seigo reopened this revision.Sep 19 2016, 1:36 PM