Page MenuHomekolab.org
Differential D207

Consider event duration and calendar_timeslots setting in availability finder (#5469, T1381)
ClosedPublic
Actions

Authored by machniak on Aug 16 2016, 3:19 PM.

Details

Reviewers
None
Group Reviewers
Roundcube Kolab Plugins Developers
Commits
rRPKbf1a8c62e747: Consider event duration and calendar_timeslots setting in availability finder…
rRPKd575d09fd57a: Consider event duration and calendar_timeslots setting in availability finder…
Summary
  1. "Previous Slot" action moves the selection box to the beginning of the time slot not the end. It looked to me as an obvious mistake.
  2. Both "previous slot" and "next slot" move the selection box in intervals defined in calendar_timeslots option instead of one hour. I.e. it will be one hour, 30 minutes, 20 minutes, 15 minutes or 10 minutes, depending what's configured in Preferences > Calendar > Time slots per hour.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak updated this revision to Diff 453.Aug 16 2016, 3:19 PM
machniak retitled this revision from to Consider event duration and calendar_timeslots setting in availability finder (#5469).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: Roundcube Kolab Plugins Developers.
machniak updated this revision to Diff 454.Aug 16 2016, 4:13 PM

Fixed allDay event availability finding

machniak updated this revision to Diff 532.Oct 4 2016, 2:45 PM

Make the number of slots in an hour here should depend on Preferences > Calendar > Time slots per hour (T1381)

machniak retitled this revision from Consider event duration and calendar_timeslots setting in availability finder (#5469) to Consider event duration and calendar_timeslots setting in availability finder (#5469, T1381).Oct 6 2016, 12:10 PM
Closed by commit rRPKd575d09fd57a: Consider event duration and calendar_timeslots setting in availability finder… (authored by machniak). · Explain WhyOct 18 2016, 9:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 581

View Options

plugins/calendar/calendar.php

Loading...
View Options

plugins/calendar/calendar_ui.js

Loading...
View Options

plugins/calendar/skins/larry/calendar.css

Loading...