Page MenuHomePhorge
Differential D150

Prepare fix - Error while updating search collection
ClosedPublic
Actions

Authored by • knauss on May 2 2016, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 6:05 AM
Unknown Object (File)
Thu, Oct 31, 8:10 PM
Unknown Object (File)
Wed, Oct 23, 11:13 AM
Unknown Object (File)
Wed, Oct 23, 11:02 AM
Unknown Object (File)
Wed, Oct 23, 11:01 AM
Unknown Object (File)
Wed, Oct 23, 10:29 AM
Unknown Object (File)
Wed, Oct 23, 10:27 AM
Unknown Object (File)
Wed, Oct 23, 10:18 AM
View All Files
Subscribers
None

Details

Reviewers
mollekopf
Maniphest Tasks
T1226: Error while updating search collection
Commits
rA6d9d27ebe934: Prepare fix - Error while updating search collection
rAf995b02854fb: Prepare fix - Error while updating search collection
Summary

Current theorie, if the error:
Cannot add or update a child row: a foreign key constraint fails
(akonadi.collectionpimitemrelation,

CONSTRAINT `collectionpimitemrelation_ibfk_2`
FOREIGN KEY (`PimItem_id`)
REFERENCES `pimitemtable` (`id`)
ON DELETE CASCADE
ON UPDATE CASCADE)"

Collection::addPimItem is performed for items in PimItem, that do not exist anymore.
This patch added a debug message, what items are not vaild anymore in PimItem.

Test Plan

mollekopf tests this patch on this installation and give results back,
if we hit the correct part to fix it.

Diff Detail

Repository
rA akonadi
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• knauss updated this revision to Diff 311.May 2 2016, 12:11 PM
• knauss retitled this revision from to Prepare fix - Error while updating search collection.
• knauss updated this object.
• knauss edited the test plan for this revision. (Show Details)
• knauss added a reviewer: mollekopf.
• knauss added a task: T1226: Error while updating search collection .
• knauss mentioned this in T1226: Error while updating search collection .May 2 2016, 12:18 PM
mollekopf accepted this revision.May 2 2016, 12:22 PM
mollekopf edited edge metadata.
This revision is now accepted and ready to land.May 2 2016, 12:22 PM
Closed by commit rAf995b02854fb: Prepare fix - Error while updating search collection (authored by Sandro Knauß <sknauss@kde.org>). · Explain WhyMay 2 2016, 12:26 PM
This revision was automatically updated to reflect the committed changes.
• knauss reopened this revision.May 12 2016, 10:35 AM

this does not fix the issue and i rework this patch

This revision is now accepted and ready to land.May 12 2016, 10:35 AM
• knauss updated this revision to Diff 345.May 12 2016, 10:48 AM
• knauss edited edge metadata.

now it checks if we have anything to add and do not crash,
if there is is nothing to add.

mollekopf added a comment.May 12 2016, 5:27 PM

Ship it! (you already accepted it)

Closed by commit rA6d9d27ebe934: Prepare fix - Error while updating search collection (authored by Sandro Knauß <sknauss@kde.org>). · Explain WhyMay 12 2016, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
server/
src/
search/
30 lines

Diff 347

View Options

server/src/search/searchmanager.cpp

Loading...