Page MenuHomekolab.org

Do not try tp load invalid scripts.
ClosedPublic

Authored by knauss on Apr 26 2016, 8:06 PM.

Details

Summary

It can happen, that if the server supports KEP:14, the USER file is the only
file that exists and that it is empty. In case we are at the end of the list
of avaialbe scripts, we should not try to load a next element from the list.

There is no vacation script in KEP:14 special files

Diff Detail

Repository
rKP kdepim
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

knauss updated this revision to Diff 292.Apr 26 2016, 8:06 PM
knauss retitled this revision from to Do not try tp load invalid scripts..
knauss updated this object.
knauss added a reviewer: mollekopf.
mollekopf accepted this revision.Apr 26 2016, 10:06 PM
mollekopf edited edge metadata.

Does this fix the crash as well?

This revision is now accepted and ready to land.Apr 26 2016, 10:06 PM

well i can't tell for sure, because I can't trigger the crash in

#5 0x00007f593c9672b0 in KUrl::setFileName(QString const&) () from
/usr/lib/libkdecore.so.5

but I searched for occurrence inside sive handling and this is the only occurence that makes sense, that it breaks here. For me it crashes with endof list (line 173) because if isLastScript() is true than mScriptPos it too high.

So in the end it - i think it makes sense to push the fix to genua and they have to test if it fix the issue.

Closed by commit rKPe485c87e0fc2: Do not try tp load invalid scripts. (authored by Sandro Knauß <sknauss@kde.org>). · Explain WhyApr 26 2016, 10:16 PM
This revision was automatically updated to reflect the committed changes.