Page MenuHomekolab.org

Avoid serializing to string
ClosedPublic

Authored by mollekopf on Apr 30 2020, 6:16 PM.

Details

Summary

saveXml() serializes to a string which instantly doubles the memory
usage. Since the DOMDocument API doesn't allow us to write to the
php://temp stream we write to a temporary file instead.

Diff Detail

Repository
rS syncroton
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Apr 30 2020, 6:16 PM
mollekopf created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 11:50 AM
This revision was automatically updated to reflect the committed changes.