Avoid serializing to string
ClosedPublic
Actions

Authored by mollekopf on Apr 30 2020, 6:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 12:44 AM

	Unknown Object (File)
	Mon, Apr 8, 6:13 AM

	Unknown Object (File)
	Feb 15 2024, 3:22 AM

	Unknown Object (File)
	Feb 12 2024, 1:36 PM

	Unknown Object (File)
	Feb 10 2024, 10:14 PM

	Unknown Object (File)
	Feb 10 2024, 9:49 PM

	Unknown Object (File)
	Jan 25 2024, 4:54 AM

	Unknown Object (File)
	Jan 18 2024, 7:58 PM

View All 29 Files

Subscribers

None

Details

Reviewers

None

Group Reviewers

Syncroton Developers

Commits

rS6a795d53eefc: Avoid serializing to string

Summary

saveXml() serializes to a string which instantly doubles the memory
usage. Since the DOMDocument API doesn't allow us to write to the
php://temp stream we write to a temporary file instead.

Diff Detail

Repository

rS syncroton

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Apr 30 2020, 6:16 PM

mollekopf created this revision.

Harbormaster completed remote builds in B29323: Diff 3187.Apr 30 2020, 6:16 PM

mollekopf added a reviewer: Syncroton Developers.Apr 30 2020, 6:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 11:50 AM

Closed by commit rS6a795d53eefc: Avoid serializing to string (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

ext/

Syncroton/

Server.php

9 lines

Wbxml/

Encoder.php

7 lines

Diff 3205

View Options

lib/ext/Syncroton/Server.php