Page MenuHomekolab.org

Match both '*' and '%' as being a wildcard.
AbandonedPublic

Authored by seigo on Mar 22 2016, 10:00 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Maniphest Tasks
T1144: Guam does not filter groupware folders on '%' wildcard use
Summary

Resolves T1144

Test Plan

Run a Thunderbird client against a Guam proxy

IMPORTANT: This is a hotfix type thing against the stable guam-0.7 branch, and is already being shipped as a patch on top of the tagged guam-0.7.2 release.

Diff Detail

Repository
rG guam
Branch
dev/guam-0.7/T1144
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3195
Build 3170: arc lint + arc unit

Event Timeline

vanmeeuwen updated this revision to Diff 230.Mar 22 2016, 10:00 AM
vanmeeuwen retitled this revision from to Match both '*' and '%' as being a wildcard..
vanmeeuwen updated this object.
vanmeeuwen edited the test plan for this revision. (Show Details)
vanmeeuwen added a reviewer: Restricted Project.
vanmeeuwen added a subscriber: seigo.

correct fix is in 68385bd in the develop branch.

apps/kolab_guam/src/rules/kolab_guam_rule_filter_groupware.erl
40

this will actually return a tuple of the form { first, second } (e.g. { nomatch, nomatch }), which means the nomatch branch will never be selected, and metadata will always be fetched.

seigo commandeered this revision.May 9 2016, 11:28 AM
seigo added a reviewer: vanmeeuwen.

fixed in develop branch

seigo abandoned this revision.May 9 2016, 11:28 AM